Skip to content

GH-131238: More refactoring of core header files #131351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 17, 2025
Merged

GH-131238: More refactoring of core header files #131351

merged 6 commits into from
Mar 17, 2025

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Mar 17, 2025 •
edited by bedevere-app bot
Loading

Breaks a few more dependencies between header files and adds a lot of more fine grained includes to .c files.

@bedevere-app bedevere-app bot mentioned this pull request Mar 17, 2025
Closed
@markshannon markshannon mentioned this pull request Mar 17, 2025
Merged
@markshannon markshannon marked this pull request as ready for review March 17, 2025 13:42
@markshannon markshannon merged commit a45f253 into python:main Mar 17, 2025
69 checks passed
@markshannon markshannon deleted the core-header-refactor-2 branch March 17, 2025 17:23
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
@markshannon @plashchynski
pythonGH-131238: More refactoring of core header files (pythonGH-131351)
6b86c9d 
Adds new pycore_stats.h header file to help break dependencies involving the pycore_code.h header.
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@markshannon @seehwan80
pythonGH-131238: More refactoring of core header files (pythonGH-131351)
5eae218 
Adds new pycore_stats.h header file to help break dependencies involving the pycore_code.h header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

@Eclips4 Eclips4 Awaiting requested review from Eclips4 Eclips4 is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

@carljm carljm Awaiting requested review from carljm carljm is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markshannon @iritkatriel