Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-131325: fix sendfile fallback implementation to drain data after writing to transport #131376

Merged
merged 3 commits into from
Mar 17, 2025
Merged

gh-131325: fix sendfile fallback implementation to drain data after writing to transport #131376

merged 3 commits into from
Mar 17, 2025

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Mar 17, 2025 •
edited by bedevere-app bot
Loading

@kumaraditya303 kumaraditya303 added type-bug An unexpected behavior, bug, or error topic-asyncio labels Mar 17, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 17, 2025
Closed
@kumaraditya303 kumaraditya303 added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Mar 17, 2025
colesbury
colesbury approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303 kumaraditya303 merged commit 94f4d87 into python:main Mar 17, 2025
47 checks passed
@miss-islington-app
Copy link

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 17, 2025
@kumaraditya303 @miss-islington
pythongh-131325: fix sendfile fallback implementation to drain data a…
ec2c54e 
…fter writing to transport (pythonGH-131376)

(cherry picked from commit 94f4d87)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 17, 2025

GH-131377 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 17, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 17, 2025
@kumaraditya303 @miss-islington
pythongh-131325: fix sendfile fallback implementation to drain data a…
484b8f2 
…fter writing to transport (pythonGH-131376)

(cherry picked from commit 94f4d87)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 17, 2025

GH-131378 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Mar 17, 2025
kumaraditya303 added a commit that referenced this pull request Mar 17, 2025
@miss-islington @kumaraditya303
[3.12] gh-131325: fix sendfile fallback implementation to drain data …
c1faead 
…after writing to transport (GH-131376) (#131378)

gh-131325: fix sendfile fallback implementation to drain data after writing to transport (GH-131376)
(cherry picked from commit 94f4d87)

Co-authored-by: Kumar Aditya <[email protected]>
kumaraditya303 added a commit that referenced this pull request Mar 17, 2025
@miss-islington @kumaraditya303
[3.13] gh-131325: fix sendfile fallback implementation to drain data …
9a43485 
…after writing to transport (GH-131376) (#131377)

gh-131325: fix sendfile fallback implementation to drain data after writing to transport (GH-131376)
(cherry picked from commit 94f4d87)

Co-authored-by: Kumar Aditya <[email protected]>
colesbury pushed a commit to colesbury/cpython that referenced this pull request Mar 20, 2025
@kumaraditya303 @colesbury
pythongh-131325: fix sendfile fallback implementation to drain data a…
43125f3 
…fter writing to transport (python#131376)
@kumaraditya303 kumaraditya303 deleted the transp branch March 23, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
topic-asyncio type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumaraditya303 @colesbury