Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-127405: Add
ABIFLAGS
tosysconfig.get_config_vars()
on Windows #131799New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-127405: Add
ABIFLAGS
tosysconfig.get_config_vars()
on Windows #131799Changes from 47 commits
31b7eab
dc45897
9a4586a
76c85bb
b98419b
4729f76
04cbb1c
a6045ea
584e0b0
93257be
30c7b56
97942b2
917874c
f49067e
8fa952b
08d92db
b667dd9
30cf6c7
5df9540
018aae3
4f22ff3
f918241
a4646c5
7b21d7d
1ee8230
084deac
af50632
b397f40
1a82cd1
7990798
0744690
518137b
486e2a8
3bccf1d
780f340
98c26f9
e236bc7
0d8bcdd
278556c
5689c1f
299cec6
21d2e73
d265a59
f3b8570
fe4ea95
da2b4ce
64f0961
8b16454
1c807f0
fbb86f5
b702ff9
932386c
23b6e6c
75b6c51
3c91201
d55b3e6
a084070
d2255e6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is guaranteed. Yes, we require it for Windows, but it may not be so for all platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition has been held since Python 3.8 to today (3.14dev).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't know if it's guaranteed.
Show me the definition of
ABIFLAGS
that specifies it (trick question - no such definition exists).Let's not invent a specification in a barely-related PR. Make this a Windows-specific test that checks for
_d
at the end (or just check'd' in ABIFLAGS
), but don't touch other platforms.