gh-119605: Preserve class signature after wrapping with @warnings.deprecated
#132055
+71
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
force-pushed
the
deprecated-signature
branch
from
2758c37 to
aa8865e
Compare
skirpichev
reviewed
Apr 4, 2025
XuehaiPan
commented
Apr 4, 2025
| import functools | ||
| from types import MethodType | ||
|
|
||
| original_new = arg.__new__ | ||
| is_object_new = original_new is object.__new__ | ||
|
|
||
| @functools.wraps(original_new) | ||
| def __new__(cls, *args, **kwargs): |
There was a problem hiding this comment.
A question might be out of the scope of this PR: Should we make cls a positional-only argument?
Suggested change
| def __new__(cls, *args, **kwargs): | |
| def __new__(cls, /, *args, **kwargs): |
A 'cls' key will never be collected in kwargs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a case in #119605 (comment).
__new__and__init_subclass__methods generated bywarnings.deprecated#119605