gh-131798: JIT: Narrow the return type of _CONTAINS_OP_SET to bool
#132057
+35
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instruction after _CONTAINS_OP_SET by setting the return type to bool.
tomasr8
commented
Apr 3, 2025
Comment on lines
+1616
to
+1622
| x = 0 | ||
| s = {1, 2, 3} | ||
| for _ in range(n): | ||
| a = 2 | ||
| in_set = a in s | ||
| if in_set: | ||
| x += 1 |
There was a problem hiding this comment.
We might be able to simplify this further, I wasn't sure how much the peepholer would optimize out if I used e.g. 2 in s directly.
There was a problem hiding this comment.
2 in s would have been fine, but this works well too!
Fidget-Spinner
approved these changes
Apr 4, 2025
brandtbucher
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context: #130415 (comment)
I did run
make regen-casesand made sure that the test failed before making the change inoptimizer_bytecodes.c:)