Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] gh-131912: Refactor description of grouping options in format specification docs (GH-132030) #132123

Merged
merged 10 commits into from
Apr 7, 2025

Conversation

Prometheus3375
Copy link
Contributor

@Prometheus3375 Prometheus3375 commented Apr 5, 2025


Key changes from the original PR:

  1. grouping is placed after width (in original PR it is after precision).
  2. Support for fractional part is not mentioned as it is introduced in 3.14.

📚 Documentation preview 📚

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Apr 5, 2025
@Prometheus3375 Prometheus3375 changed the title [3.13] Refactor description of grouping options in format specification docs (GH-132030) [3.13] gh-131912: Refactor description of grouping options in format specification docs (GH-132030) Apr 5, 2025
@skirpichev skirpichev added the needs backport to 3.12 only security fixes label Apr 5, 2025
@skirpichev skirpichev requested a review from picnixz April 5, 2025 13:18
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

picnixz

This comment was marked as resolved.

@picnixz

This comment was marked as resolved.

@picnixz picnixz self-assigned this Apr 6, 2025
@picnixz
Copy link
Member

picnixz commented Apr 6, 2025

I'll merge the PR tomorrow! thanks for the work

@Prometheus3375
Copy link
Contributor Author

Prometheus3375 commented Apr 6, 2025

I saw the question was resolved, but I still answer. I also updated PR description is well.


Here are changes compared to 3.14 (string copy.rst). It marks precision as moved, because grouping is placed after width here, but after precision in 3.14.

image
image
image
image

@picnixz picnixz merged commit 07483c2 into python:3.13 Apr 7, 2025
26 checks passed
@miss-islington-app
Copy link

Thanks @Prometheus3375 for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 7, 2025
…e format specification docs (pythonGH-132030) (pythonGH-132123)

(cherry picked from commit 07483c2)

Co-authored-by: Prometheus3375 <[email protected]>
(cherry picked from commit 06a110f)
@picnixz
Copy link
Member

picnixz commented Apr 7, 2025

I hope this won't have conflicts in 3.12.

@bedevere-app
Copy link

bedevere-app bot commented Apr 7, 2025

GH-132203 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 7, 2025
@Prometheus3375 Prometheus3375 deleted the gh-131912-313 branch April 7, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants