Skip to content

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Sep 16, 2025

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk hugovk merged commit 207f977 into python:main Oct 14, 2025
53 checks passed
@hugovk hugovk added awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 14, 2025
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2025
(cherry picked from commit 207f977)

Co-authored-by: Stan Ulbrych <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2025
(cherry picked from commit 207f977)

Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 14, 2025

GH-140087 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 14, 2025
@bedevere-app
Copy link

bedevere-app bot commented Oct 14, 2025

GH-140088 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 14, 2025
@StanFromIreland StanFromIreland deleted the credits-dedent branch October 14, 2025 12:39
hugovk pushed a commit that referenced this pull request Oct 15, 2025
hugovk pushed a commit that referenced this pull request Oct 15, 2025
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian Linux Asan 3.14 (no tier) has failed when building commit 9e235ff.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1816/builds/78) and take a look at the build logs.
  4. Check if the failure is related to this commit (9e235ff) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1816/builds/78

Summary of the results of the build (if available):

Click to see traceback logs
remote: Enumerating objects: 15, done.        
remote: Counting objects:  10% (1/10)        
remote: Counting objects:  20% (2/10)        
remote: Counting objects:  30% (3/10)        
remote: Counting objects:  40% (4/10)        
remote: Counting objects:  50% (5/10)        
remote: Counting objects:  60% (6/10)        
remote: Counting objects:  70% (7/10)        
remote: Counting objects:  80% (8/10)        
remote: Counting objects:  90% (9/10)        
remote: Counting objects: 100% (10/10)        
remote: Counting objects: 100% (10/10), done.        
remote: Compressing objects:  20% (1/5)        
remote: Compressing objects:  40% (2/5)        
remote: Compressing objects:  60% (3/5)        
remote: Compressing objects:  80% (4/5)        
remote: Compressing objects: 100% (5/5)        
remote: Compressing objects: 100% (5/5), done.        
remote: Total 15 (delta 5), reused 5 (delta 5), pack-reused 5 (from 2)        
From https://github.com/python/cpython
 * branch                    3.14       -> FETCH_HEAD
Note: switching to '9e235ffb215fcf31f8792a37e8a935741e8d3097'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 9e235ffb215 [3.14] gh-138993: Dedent `credits` text (GH-138994) (#140088)
Switched to and reset branch '3.14'

configure: WARNING: no system libmpdec found; falling back to bundled libmpdec (deprecated and scheduled for removal in Python 3.16)

In file included from ./Include/internal/pycore_dict.h:11,
                 from Objects/typeobject.c:7:
In function ‘Py_DECREF_MORTAL’,
    inlined from ‘PyStackRef_XCLOSE’ at ./Include/internal/pycore_stackref.h:660:9,
    inlined from ‘_PyThreadState_PopCStackRef’ at ./Include/internal/pycore_stackref.h:746:5,
    inlined from ‘vectorcall_maybe’ at Objects/typeobject.c:2984:9:
./Include/internal/pycore_object.h:481:8: warning: array subscript 0 is outside array bounds of ‘PyObject[0]’ {aka ‘struct _object[]’} [-Warray-bounds]
  481 |     if (--op->ob_refcnt == 0) {
      |        ^

Timeout (0:05:00)!
Thread 0x0000007faefef100 [Thread-2] (most recent call first):
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/subprocess.py", line 2043 in _wait
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/subprocess.py", line 1278 in wait
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 194 in _run_process
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 299 in run_tmp_files
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 363 in _runtest
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 403 in run
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/threading.py", line 1082 in _bootstrap_inner
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/threading.py", line 1044 in _bootstrap

Thread 0x0000007faf7ff100 [Thread-1] (most recent call first):
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/subprocess.py", line 2058 in _wait
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/subprocess.py", line 1278 in wait
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 194 in _run_process
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 299 in run_tmp_files
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 363 in _runtest
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 403 in run
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/threading.py", line 1082 in _bootstrap_inner
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/threading.py", line 1044 in _bootstrap

Thread 0x0000007fbb5316c0 [python] (most recent call first):
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 536 in _get_result
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 610 in run
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 455 in _run_tests_mp
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 561 in _run_tests
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 598 in run_tests
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 779 in main
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 787 in main
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/__main__.py", line 2 in <module>
  File "<frozen runpy>", line 88 in _run_code
  File "<frozen runpy>", line 198 in _run_module_as_main
make: *** [Makefile:2496: buildbottest] Error 1

Cannot open file '/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/test-results.xml' for upload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants