gh-76007: Deprecate zlib.__version__ attribute
#140130
Merged
+38
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Oct 14, 2025
vstinner
reviewed
Oct 14, 2025
StanFromIreland
commented
Oct 15, 2025
vstinner
approved these changes
Oct 15, 2025
| ZLIB_CRC32_COMBINE_METHODDEF | ||
| ZLIB_DECOMPRESS_METHODDEF | ||
| ZLIB_DECOMPRESSOBJ_METHODDEF | ||
| {"__getattr__", zlib_getattr, METH_VARARGS, "Module __getattr__"}, |
There was a problem hiding this comment.
I tried to convert the function to Argument Clinic, but it failed, oh!
Error in file 'Modules/zlibmodule.c' on line 2019:
'__getattr__' is a special method and cannot be converted to Argument Clinic!
There was a problem hiding this comment.
I tried that too :-)
|
Merged, thanks. I also saw that version but forgot to deprecate it :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--140130.org.readthedocs.build/