Skip to content

gh-142353: Isolate tests from personal GNU Readline init files #142370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 3 commits into from
Dec 12, 2025
Merged

gh-142353: Isolate tests from personal GNU Readline init files #142370

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4de3631
Isolate tests from personal Readline init files using `INPUTRC=/dev/n…
johnslavik Dec 7, 2025
1c6153a
Remove readline logic (it is unnecessary)
johnslavik Dec 11, 2025
6c2d108
Merge branch 'main' into isolate-from-inputrc
johnslavik Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Lib/test/support/pty_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,22 @@

from test.support.import_helper import import_module

def run_pty(script, input=b"dummy input\r", env=None):
def run_pty(script, input=b"dummy input\r", env=None, readline=None):
pty = import_module('pty')
output = bytearray()
[master, slave] = pty.openpty()
args = (sys.executable, '-c', script)

if readline is None:
readline = "readline" in sys.modules
if readline:
# Isolate readline from personal init files by setting INPUTRC
# to an empty file. See also GH-142353.
if env is None:
env = {**os.environ.copy(), "INPUTRC": os.devnull}
else:
env.setdefault("INPUTRC", os.devnull)

proc = subprocess.Popen(args, stdin=slave, stdout=slave, stderr=slave, env=env)
os.close(slave)
with ExitStack() as cleanup:
Expand Down
Loading