gh-1542: Do not suggest make -j
#1543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imit on the number of concurrent jobs, not "a sensible limit considering the available memory and CPU cores". With LTO it's easy to run out of memory when too many jobs run at the same time.
hugovk
reviewed
Apr 18, 2025
| @@ -547,8 +547,11 @@ Now that the configuration is in place, it remains to compile the project: | |||
| .. tip:: | |||
|
|
|||
| Use ``make -j`` to speed-up compilation by utilizing as many CPU cores | |||
| as possible or ``make -jN`` to allow at most *N* concurrent jobs. | |||
| Use ``make -jN`` to speed-up compilation by utilizing as many CPU cores | |||
There was a problem hiding this comment.
Suggested change
| Use ``make -jN`` to speed-up compilation by utilizing as many CPU cores | |
| Use ``make -jN`` to speed-up compilation by using as many CPU cores |
|
Closing in favour of #1541. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not suggest
make -jfor building CPython.make -jmeans no limit onthe number of concurrent jobs, not "a sensible limit considering the available memory and CPU cores". With LTO it's easy to run out of memory when too many jobs run at the same time.
📚 Documentation preview 📚: https://cpython-devguide--1543.org.readthedocs.build/