Do not cache module lookup results that may become invalid in future #19044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
I don't see how to deal with the whole problem yet, but this looks like a sensible first step. The issue ultimately is that we treat namespace ancestors of typed packages as if they were typed. We only start doing that once we are actually aware of some nested typed subpackages, and this causes issues I linked above. At least removing the cache dependency is good IMO, but I'll need to look deeper to find a complete solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19037. See my analysis in #19037 for motivation. As a side note, with this patch the second run behaves as expected (without it mypy tries to reanalyze a lot of modules during the 2nd run, now it only rechecks the inputs with errors).