feat: index-range err code #19513
Draft
feat: index-range err code #19513
+232
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
|
one was a true positive, one was a false positive I've fixed the code to handle the false positive case correctly |
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: cloud-init (https://github.com/canonical/cloud-init)
+ tests/unittests/test_url_helper.py:601: error: Sequence index out of range: '<expr>' only has 0 items [index-range]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is WIP. I just need the primer to run to help me figure out if I'm on a good path.
I'm not sure if this is even desired, but after building my PR for the mypyc length stuff (#19503 ) I decided to attempt to integrate it into higher level mypy stuff. This could enable new error codes such as index-range for an index which is known to be out of range
If this makes sense to add to mypy, and I am already working on similar length-based static analysis for optimizing mypyc, then I should try to proceed in as DRY a manner as possible.
Some of these internals could be repurposed in the future to allow mypy to determine the specific types of list items in some cases, even if the list itself is, for example,
List[str | int]