Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HeimdalRealm: fix missing comma in stash command #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

HeimdalRealm: fix missing comma in stash command #30

wants to merge 1 commit into from

Conversation

svmhdvn
Copy link

@svmhdvn svmhdvn commented Jun 17, 2024 •
edited
Loading

No description provided.

@svmhdvn svmhdvn marked this pull request as draft June 17, 2024 17:16
@jborean93
Copy link
Contributor

Can you share what you are trying to fix, admin on Heimdal only documents --random-password and not --random-key for the stash command https://github.com/heimdal/heimdal/blob/1b57b62d82a478c1fade350f0fb1d57031a8734e/kadmin/kadmin-commands.in#L35-L70. I've also used the current code for Heimdal installs without issues as well so knowing what the underlying problem is will help with this review.

@svmhdvn svmhdvn changed the title HeimdalRealm: fix wrong --random-password to kstash cmd HeimdalRealm: fix missing comma in stash command Jun 17, 2024
@svmhdvn svmhdvn marked this pull request as ready for review June 17, 2024 20:09
@svmhdvn
Copy link
Author

svmhdvn commented Jun 17, 2024

Sorry, I didn't fully understand the issue before, but found the typo now.

This was referenced Nov 5, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svmhdvn @jborean93