[Benchmark] Add initial TritonBench integration and vector_add benchmark example #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jansel
requested changes
Jul 8, 2025
benchmark/run.py
Outdated
Comment on lines
61
to
63
| # Add to path | ||
| if tritonbench_path not in sys.path: | ||
| sys.path.insert(0, tritonbench_path) |
There was a problem hiding this comment.
Modifying the path is a bit hacky. Could we do pip install git+https://github.com/pytorch-labs/tritonbench.git or (cd tritonbench && pip install -e .)? (If the git one works we wont need a submodule.)
There was a problem hiding this comment.
I found that tritonbench needs custom installation of dependencies via python install.py which is not run when doing pip install. Currently I removed the submodule but do a git clone within the run.py file so that we can cd into the folder to be able to run install.py (but would be curious for other cleaner approaches too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Support running Helion benchmark via a single-line command:
python benchmark/run.py --metrics speedup,accuracy --kernel vector_addThanks @xuzhao9 for help with authoring pytorch-labs/tritonbench@09b42e8 and also reviewing pytorch-labs/tritonbench@2237731, which are dependencies for this PR.