Make kv_cache tests device agnostic#3961
Closed
PatriceVignola wants to merge 1 commit intopytorch:mainfrom
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72370780 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PatriceVignola
force-pushed
the
export-D72370780
branch
from
0dfd371 to
7377ea2
Compare
PatriceVignola
added a commit
to PatriceVignola/FBGEMM-1
that referenced
this pull request
Apr 15, 2025
Summary: X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
PatriceVignola
added a commit
to PatriceVignola/FBGEMM-1
that referenced
this pull request
Apr 15, 2025
Summary: X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
PatriceVignola
force-pushed
the
export-D72370780
branch
from
7377ea2 to
fc4909d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72370780 |
PatriceVignola
added a commit
to PatriceVignola/FBGEMM-1
that referenced
this pull request
Apr 15, 2025
Summary: Pull Request resolved: pytorch#3961 X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
PatriceVignola
force-pushed
the
export-D72370780
branch
from
fc4909d to
2543862
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72370780 |
PatriceVignola
added a commit
to PatriceVignola/FBGEMM-1
that referenced
this pull request
Apr 15, 2025
Summary: Pull Request resolved: pytorch#3961 X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
PatriceVignola
force-pushed
the
export-D72370780
branch
from
2543862 to
9832bb8
Compare
PatriceVignola
added a commit
to PatriceVignola/FBGEMM-1
that referenced
this pull request
Apr 15, 2025
Summary: X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
PatriceVignola
force-pushed
the
export-D72370780
branch
2 times, most recently
from
9719ec6 to
f657ab6
Compare
PatriceVignola
added a commit
to PatriceVignola/FBGEMM-1
that referenced
this pull request
Apr 15, 2025
Summary: X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72370780 |
PatriceVignola
added a commit
to PatriceVignola/FBGEMM-1
that referenced
this pull request
Apr 15, 2025
Summary: Pull Request resolved: pytorch#3961 X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
PatriceVignola
force-pushed
the
export-D72370780
branch
from
f657ab6 to
1c22f9d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72370780 |
PatriceVignola
added a commit
to PatriceVignola/FBGEMM-1
that referenced
this pull request
Apr 15, 2025
Summary: Pull Request resolved: pytorch#3961 X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
PatriceVignola
force-pushed
the
export-D72370780
branch
2 times, most recently
from
b81febb to
42e02bf
Compare
PatriceVignola
added a commit
to PatriceVignola/FBGEMM-1
that referenced
this pull request
Apr 16, 2025
Summary: X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
PatriceVignola
added a commit
to PatriceVignola/FBGEMM-1
that referenced
this pull request
Apr 16, 2025
Summary: X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
PatriceVignola
force-pushed
the
export-D72370780
branch
from
42e02bf to
c90d26a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72370780 |
PatriceVignola
added a commit
to PatriceVignola/FBGEMM-1
that referenced
this pull request
Apr 16, 2025
Summary: Pull Request resolved: pytorch#3961 X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
PatriceVignola
force-pushed
the
export-D72370780
branch
from
c90d26a to
ef2a52e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72370780 |
PatriceVignola
added a commit
to PatriceVignola/FBGEMM-1
that referenced
this pull request
Apr 16, 2025
Summary: Pull Request resolved: pytorch#3961 X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
PatriceVignola
force-pushed
the
export-D72370780
branch
2 times, most recently
from
948907e to
98b61b5
Compare
PatriceVignola
added a commit
to PatriceVignola/FBGEMM-1
that referenced
this pull request
Apr 16, 2025
Summary: X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
PatriceVignola
added a commit
to PatriceVignola/FBGEMM-1
that referenced
this pull request
Apr 16, 2025
Summary: X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
PatriceVignola
force-pushed
the
export-D72370780
branch
from
98b61b5 to
c5e2e3f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72370780 |
PatriceVignola
added a commit
to PatriceVignola/FBGEMM-1
that referenced
this pull request
Apr 16, 2025
Summary: Pull Request resolved: pytorch#3961 X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
PatriceVignola
force-pushed
the
export-D72370780
branch
from
c5e2e3f to
07d2053
Compare
Summary: Pull Request resolved: pytorch#3961 X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72370780 |
PatriceVignola
force-pushed
the
export-D72370780
branch
from
07d2053 to
598f2df
Compare
brad-mengchi
approved these changes
Apr 17, 2025
brad-mengchi
pushed a commit
to brad-mengchi/FBGEMM
that referenced
this pull request
Apr 17, 2025
Summary: Pull Request resolved: pytorch#3961 X-link: facebookresearch/FBGEMM#1044 The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it. Differential Revision: D72370780
Contributor
|
This pull request has been merged in 30d2973. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The kv_cache tests are currently hardcoded to use CUDA, but we want to be able to hook other devices to it.
Differential Revision: D72370780