-
Notifications
You must be signed in to change notification settings - Fork 622
TensorAccessor
cleanup
#3973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TensorAccessor
cleanup
#3973
Conversation
This pull request was exported from Phabricator. Differential Revision: D72940055 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Summary: - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
Summary: - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
This pull request was exported from Phabricator. Differential Revision: D72940055 |
Summary: Pull Request resolved: pytorch#3973 - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
This pull request was exported from Phabricator. Differential Revision: D72940055 |
Summary: X-link: facebookresearch/FBGEMM#1059 Pull Request resolved: pytorch#3973 - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
This pull request was exported from Phabricator. Differential Revision: D72940055 |
Summary: X-link: facebookresearch/FBGEMM#1059 - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
Summary: X-link: facebookresearch/FBGEMM#1059 - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
Summary: X-link: facebookresearch/FBGEMM#1059 - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
This pull request was exported from Phabricator. Differential Revision: D72940055 |
Summary: X-link: facebookresearch/FBGEMM#1059 Pull Request resolved: pytorch#3973 - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
This pull request was exported from Phabricator. Differential Revision: D72940055 |
Summary: X-link: facebookresearch/FBGEMM#1059 Pull Request resolved: pytorch#3973 - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
Summary: X-link: facebookresearch/FBGEMM#1059 - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
This pull request was exported from Phabricator. Differential Revision: D72940055 |
This pull request has been merged in ac052db. |
Summary:
tensor_accessor.h
duplicates a lot of code fromATen/core/TensorAccessor.h
. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead.Reviewed By: sryap
Differential Revision: D72940055