Skip to content

TensorAccessor cleanup #3973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

TensorAccessor cleanup #3973

wants to merge 1 commit into from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Apr 16, 2025

Summary:

  • The existing tensor_accessor.h duplicates a lot of code from ATen/core/TensorAccessor.h. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead.
  • Add unit tests to check that the index checking works.

Reviewed By: sryap

Differential Revision: D72940055

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72940055

Copy link

netlify bot commented Apr 16, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 27fcf1d
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/6800b79a935ade000837bfd7
😎 Deploy Preview https://deploy-preview-3973--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

q10 added a commit to q10/FBGEMM that referenced this pull request Apr 17, 2025
Summary:

- The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`.  This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. 
- Add unit tests to check that the index checking works.

Reviewed By: sryap

Differential Revision: D72940055
@q10 q10 force-pushed the export-D72940055 branch from ef6dfb5 to a425e9c Compare April 17, 2025 01:26
q10 added a commit to q10/FBGEMM that referenced this pull request Apr 17, 2025
Summary:

- The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`.  This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. 
- Add unit tests to check that the index checking works.

Reviewed By: sryap

Differential Revision: D72940055
@q10 q10 force-pushed the export-D72940055 branch from a425e9c to 509606d Compare April 17, 2025 01:27
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72940055

q10 added a commit to q10/FBGEMM that referenced this pull request Apr 17, 2025
Summary:
Pull Request resolved: pytorch#3973

- The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`.  This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead.
- Add unit tests to check that the index checking works.

Reviewed By: sryap

Differential Revision: D72940055
@q10 q10 force-pushed the export-D72940055 branch from 509606d to 1761c0b Compare April 17, 2025 01:30
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72940055

q10 added a commit to q10/FBGEMM that referenced this pull request Apr 17, 2025
Summary:
X-link: facebookresearch/FBGEMM#1059

Pull Request resolved: pytorch#3973

- The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`.  This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead.
- Add unit tests to check that the index checking works.

Reviewed By: sryap

Differential Revision: D72940055
@q10 q10 force-pushed the export-D72940055 branch from 1761c0b to d6c1cf5 Compare April 17, 2025 01:36
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72940055

q10 added a commit to q10/FBGEMM that referenced this pull request Apr 17, 2025
Summary:
X-link: facebookresearch/FBGEMM#1059


- The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`.  This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. 
- Add unit tests to check that the index checking works.

Reviewed By: sryap

Differential Revision: D72940055
@q10 q10 force-pushed the export-D72940055 branch from d6c1cf5 to ced0cc4 Compare April 17, 2025 01:40
q10 added a commit to q10/FBGEMM that referenced this pull request Apr 17, 2025
Summary:
X-link: facebookresearch/FBGEMM#1059


- The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`.  This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. 
- Add unit tests to check that the index checking works.

Reviewed By: sryap

Differential Revision: D72940055
@q10 q10 force-pushed the export-D72940055 branch from ced0cc4 to ead2149 Compare April 17, 2025 04:12
q10 added a commit to q10/FBGEMM that referenced this pull request Apr 17, 2025
Summary:
X-link: facebookresearch/FBGEMM#1059


- The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`.  This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. 
- Add unit tests to check that the index checking works.

Reviewed By: sryap

Differential Revision: D72940055
@q10 q10 force-pushed the export-D72940055 branch from ead2149 to 4dc9ac2 Compare April 17, 2025 04:12
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72940055

q10 added a commit to q10/FBGEMM that referenced this pull request Apr 17, 2025
Summary:
X-link: facebookresearch/FBGEMM#1059

Pull Request resolved: pytorch#3973

- The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`.  This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead.
- Add unit tests to check that the index checking works.

Reviewed By: sryap

Differential Revision: D72940055
@q10 q10 force-pushed the export-D72940055 branch from 4dc9ac2 to 08763c7 Compare April 17, 2025 04:15
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72940055

@q10 q10 force-pushed the export-D72940055 branch from 08763c7 to 7cf1234 Compare April 17, 2025 04:21
q10 added a commit to q10/FBGEMM that referenced this pull request Apr 17, 2025
Summary:
X-link: facebookresearch/FBGEMM#1059

Pull Request resolved: pytorch#3973

- The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`.  This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead.
- Add unit tests to check that the index checking works.

Reviewed By: sryap

Differential Revision: D72940055
Summary:
X-link: facebookresearch/FBGEMM#1059


- The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`.  This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. 
- Add unit tests to check that the index checking works.

Reviewed By: sryap

Differential Revision: D72940055
@q10 q10 force-pushed the export-D72940055 branch from 7cf1234 to 27fcf1d Compare April 17, 2025 08:11
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72940055

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ac052db.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants