Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72940055 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 17, 2025
Summary: - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 17, 2025
Summary: - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72940055 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 17, 2025
Summary: Pull Request resolved: pytorch#3973 - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72940055 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 17, 2025
Summary: X-link: facebookresearch/FBGEMM#1059 Pull Request resolved: pytorch#3973 - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72940055 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 17, 2025
Summary: X-link: facebookresearch/FBGEMM#1059 - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 17, 2025
Summary: X-link: facebookresearch/FBGEMM#1059 - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 17, 2025
Summary: X-link: facebookresearch/FBGEMM#1059 - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72940055 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 17, 2025
Summary: X-link: facebookresearch/FBGEMM#1059 Pull Request resolved: pytorch#3973 - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72940055 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 17, 2025
Summary: X-link: facebookresearch/FBGEMM#1059 Pull Request resolved: pytorch#3973 - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
Summary: X-link: facebookresearch/FBGEMM#1059 - The existing `tensor_accessor.h` duplicates a lot of code from `ATen/core/TensorAccessor.h`. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead. - Add unit tests to check that the index checking works. Reviewed By: sryap Differential Revision: D72940055
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72940055 |
Contributor
|
This pull request has been merged in ac052db. |
q10
added
category:improvement
feature:tbe
feature:utils
and removed
feature:tbe
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
tensor_accessor.hduplicates a lot of code fromATen/core/TensorAccessor.h. This diff removes the duplication and simplifies the class template specializations by using SFINAE methods instead.Reviewed By: sryap
Differential Revision: D72940055