add load checkpoint support for virtual table #4250
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D75843542 |
❌ Deploy Preview for pytorch-fbgemm-docs failed.
|
Summary: after all of the rebasing and landing, the trunk still missed some of the needed changes for checkpoint loading: * change `create_virtual_table_global_metadata` to respect local_weight_count on each rank, or just use the param size as number of rows on each rank * register register_load_state_dict_post_hook in ShardedEmbeddingCollection to let it ignore loading the weight tensor Differential Revision: D75843542 Privacy Context Container: L1138451
bobbyliujb
force-pushed
the
export-D75843542
branch
from
80e6b66 to
504dec1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75843542 |
bobbyliujb
pushed a commit
to bobbyliujb/torchrec
that referenced
this pull request
Jun 3, 2025
Summary: X-link: pytorch/FBGEMM#4250 after all of the rebasing and landing, the trunk still missed some of the needed changes for checkpoint loading: * change `create_virtual_table_global_metadata` to respect local_weight_count on each rank, or just use the param size as number of rows on each rank * register register_load_state_dict_post_hook in ShardedEmbeddingCollection to let it ignore loading the weight tensor Differential Revision: D75843542 Privacy Context Container: L1138451
facebook-github-bot
pushed a commit
to pytorch/torchrec
that referenced
this pull request
Jun 4, 2025
Summary: Pull Request resolved: #3037 X-link: facebookresearch/FBGEMM#1329 X-link: pytorch/FBGEMM#4250 after all of the rebasing and landing, the trunk still missed some of the needed changes for checkpoint loading: * change `create_virtual_table_global_metadata` to respect local_weight_count on each rank, or just use the param size as number of rows on each rank * register register_load_state_dict_post_hook in ShardedEmbeddingCollection to let it ignore loading the weight tensor Reviewed By: emlin Differential Revision: D75843542 Privacy Context Container: L1138451 fbshipit-source-id: 8b3c8d76bb2e7ba2137c8899de2c03d534f1365c
|
This pull request has been merged in ee0264c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
after all of the rebasing and landing, the trunk still missed some of the needed changes for checkpoint loading:
create_virtual_table_global_metadatato respect local_weight_count on each rank, or just use the param size as number of rows on each rankDifferential Revision: D75843542