-
Notifications
You must be signed in to change notification settings - Fork 622
Adding and Exposing functions to destruct rocksDB checkpoint from ReadOnlyEmbeddingKVDB #4361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This pull request was exported from Phabricator. Differential Revision: D76737185 |
This pull request was exported from Phabricator. Differential Revision: D76737185 |
613fab1
to
54f2ada
Compare
…dOnlyEmbeddingKVDB (pytorch#4361) Summary: Pull Request resolved: pytorch#4361 X-link: facebookresearch/FBGEMM#1432 Context: The lifecycle of the rocksDB checkpoint is controlled by the client (checkpoint and publish) components. Due to this, we need to expose an API to destruct the rocksDB checkpoint and delete the folders. In this diff, we have added delete functionality Differential Revision: D76737185
This pull request was exported from Phabricator. Differential Revision: D76737185 |
…dOnlyEmbeddingKVDB (pytorch#4361) Summary: Pull Request resolved: pytorch#4361 X-link: facebookresearch/FBGEMM#1432 Context: The lifecycle of the rocksDB checkpoint is controlled by the client (checkpoint and publish) components. Due to this, we need to expose an API to destruct the rocksDB checkpoint and delete the folders. In this diff, we have added delete functionality Differential Revision: D76737185
54f2ada
to
4fb9aa7
Compare
…dOnlyEmbeddingKVDB (pytorch#4361) Summary: X-link: facebookresearch/FBGEMM#1432 Context: The lifecycle of the rocksDB checkpoint is controlled by the client (checkpoint and publish) components. Due to this, we need to expose an API to destruct the rocksDB checkpoint and delete the folders. In this diff, we have added delete functionality Differential Revision: D76737185
4fb9aa7
to
8c70959
Compare
This pull request was exported from Phabricator. Differential Revision: D76737185 |
Summary:
Context:
The lifecycle of the rocksDB checkpoint is controlled by the client (checkpoint and publish) components. Due to this, we need to expose an API to destruct the rocksDB checkpoint and delete the folders.
In this diff, we have added delete functionality
Rollback Plan:
Differential Revision: D76737185