Skip to content

Adding and Exposing functions to destruct rocksDB checkpoint from ReadOnlyEmbeddingKVDB #4361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Raahul46
Copy link

Summary:
Context:

The lifecycle of the rocksDB checkpoint is controlled by the client (checkpoint and publish) components. Due to this, we need to expose an API to destruct the rocksDB checkpoint and delete the folders.

In this diff, we have added delete functionality

Rollback Plan:

Differential Revision: D76737185

Copy link

netlify bot commented Jun 17, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 8c70959
🔍 Latest deploy log https://app.netlify.com/projects/pytorch-fbgemm-docs/deploys/686d9b3520ce3d00084520a9
😎 Deploy Preview https://deploy-preview-4361--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76737185

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76737185

Raahul46 pushed a commit to Raahul46/FBGEMM-1 that referenced this pull request Jun 18, 2025
…dOnlyEmbeddingKVDB (pytorch#4361)

Summary:
Pull Request resolved: pytorch#4361

X-link: facebookresearch/FBGEMM#1432

Context:

The lifecycle of the rocksDB checkpoint is controlled by the client (checkpoint and publish) components. Due to this, we need to expose an API to destruct the rocksDB checkpoint and delete the folders.

In this diff, we have added delete functionality

Differential Revision: D76737185
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76737185

Raahul46 pushed a commit to Raahul46/FBGEMM-1 that referenced this pull request Jun 18, 2025
…dOnlyEmbeddingKVDB (pytorch#4361)

Summary:
Pull Request resolved: pytorch#4361

X-link: facebookresearch/FBGEMM#1432

Context:

The lifecycle of the rocksDB checkpoint is controlled by the client (checkpoint and publish) components. Due to this, we need to expose an API to destruct the rocksDB checkpoint and delete the folders.

In this diff, we have added delete functionality

Differential Revision: D76737185
…dOnlyEmbeddingKVDB (pytorch#4361)

Summary:

X-link: facebookresearch/FBGEMM#1432

Context:

The lifecycle of the rocksDB checkpoint is controlled by the client (checkpoint and publish) components. Due to this, we need to expose an API to destruct the rocksDB checkpoint and delete the folders. 

In this diff, we have added delete functionality

Differential Revision: D76737185
@Raahul46 Raahul46 force-pushed the export-D76737185 branch from 4fb9aa7 to 8c70959 Compare July 8, 2025 22:26
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76737185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants