-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump TRT version to 10.7 #3313
Bump TRT version to 10.7 #3313
Conversation
9e28659
to
c8a2aab
Compare
c9d444d
to
78af8f6
Compare
78af8f6
to
1ef0133
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
d2d08a2
to
b79d234
Compare
pyproject.toml
Outdated
@@ -8,7 +8,7 @@ requires = [ | |||
"cffi>=1.15.1", | |||
"typing-extensions>=4.7.0", | |||
"future>=0.18.3", | |||
"tensorrt-cu12>=10.6.0,<10.8.0", | |||
"tensorrt-cu12==10.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do multiple TRT versions get tested now in CI with this change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should right? Also 10.6 should be supported but we need at least 10.6 because of the QDP feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean we need to keep tensorrt-cu12>=10.6.0,<10.8.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Bump TRT version to 10.7
Type of change
Checklist: