Skip to content

Enhance test_autoquant_compile to support ROCm #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enhance test_autoquant_compile to support ROCm #2100

wants to merge 3 commits into from

Conversation

petrex
Copy link
Collaborator

@petrex petrex commented Apr 22, 2025

  • Added checks for ROCm availability alongside CUDA.
  • Improved device capability checks for CUDA to ensure compatibility with bfloat16 and specific tensor shapes.
  • Updated skip conditions for unsupported devices and older PyTorch versions.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2100

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit db17c3d with merge base 2c901b3 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 22, 2025
@petrex petrex added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Apr 22, 2025
@petrex
Copy link
Collaborator Author

petrex commented Apr 22, 2025

TestQAT.test_qat_8da4w_prepare_vs_convert_* failing in CI. --> irrelevant.

@petrex
Copy link
Collaborator Author

petrex commented Apr 23, 2025

refer to #2113

@petrex
Copy link
Collaborator Author

petrex commented Apr 30, 2025 •
edited
Loading

@pytorchbot rebase -b main

@petrex petrex force-pushed the rocm_autoquant branch from 314621d to 5f113aa Compare May 5, 2025 21:18
petrex added 2 commits May 8, 2025 13:12
@petrex
Enhance test_autoquant_compile to support ROCm and improve device checks
c19defe 
- Added checks for ROCm availability alongside CUDA.
- Improved device capability checks for CUDA to ensure compatibility with bfloat16 and specific tensor shapes.
- Updated skip conditions for unsupported devices and older PyTorch versions.
@petrex
lint
66b89a2
@petrex petrex force-pushed the rocm_autoquant branch from 5f113aa to 66b89a2 Compare May 8, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ciflow/rocm CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petrex @facebook-github-bot