Skip to content

Conversation

@vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Dec 26, 2025

Summary:

Since #3473 landed which benchmarks
LLaMa models with HF model definition and vllm, we no longer need the
previous benchmarks we had which used a custom model definition.
Deleting all of them.

Note that benchmarks/_models/ is using HF model definition, but
deleting them too as #3473 is a more
modern version of these which includes performance.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Dec 26, 2025

vkuzo added a commit that referenced this pull request Dec 26, 2025
Summary:

Since #3473 landed which benchmarks
LLaMa models with HF model definition and vllm, we no longer need the
previous benchmarks we had which used a custom model definition.
Deleting all of them.

Note that `benchmarks/_models/` is using HF model definition, but
deleting them too as #3473 is a more
modern version of these which includes performance.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: 1c71a53
ghstack-comment-id: 3693211304
Pull-Request: #3552
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3552

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit a095beb with merge base 886ac8e (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 26, 2025
@vkuzo vkuzo added the topic: for developers Use this tag if this PR is mainly developer facing label Dec 26, 2025
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: for developers Use this tag if this PR is mainly developer facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants