timm_efficientdet: benchmark coverage for custom devices #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pls hold until the custom devices support for https://github.com/rwightman/efficientdet-pytorch is merged. |
weishi-deng
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
weishi-deng
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
The PR for third-party dependency rwightman/efficientdet-pytorch#299 is merged. @EikanWang pls help review again and I will mark this PR as "ready for review" if no change. |
weishi-deng
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
weishi-deng
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
EikanWang
approved these changes
Oct 8, 2024
|
@weishi-deng , Perfect! This PR is ready for review. |
weishi-deng
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
weishi-deng
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works for Roadmap #1293 to increase benchmark coverage.
This model implementation is hard-code with CUDA due to the 3rd-party repo dependency which makes that running on the custom devices except for CUDA(e.g. XPU) will raise the runtime error.
In this PR, we accept the device arg as a parameter within the training and inference processes, which will cover the model initializing and data transposition for these custom devices.