Make input & outcome transforms first class attributes of Model #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: These were previously only set when they were not None, which lead to a lot of `hasattr`, `getattr` usage throughout the codebase to check for them. This diff adds them as attributes to base `Model` class with default values of `None`. With this change, we can now access `model.input/outcome_transform` on all models. Differential Revision: D66012223
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66012223 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: These were previously only set when they were not None, which lead to a lot of
hasattr,getattrusage throughout the codebase to check for them. This diff adds them as attributes to baseModelclass with default values ofNone. With this change, we can now accessmodel.input/outcome_transformon all models.Differential Revision: D66012223