-
Notifications
You must be signed in to change notification settings - Fork 525
Qualcomm AI Engine Direct - Add rewrite function of observer #10093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
chunit-quic
commented
Apr 11, 2025
•
edited
Loading
edited
- Add function to rewrite observer after prepare_pt2e
- Add corresponding test case
- Add function to rewrite observer after prepare_pt2e - Add corresponding test case
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10093
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 2c9c79c with merge base 1d43b3b ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Hi @cccclai, This PR is for the requested functionality to overwrite a quanization parameters after calibration. It can handle shared observer too. Thank you! |
@chunit-quic thanks for putting up the pr. cc: @sxu @billmguo |
Mind sharing a bit more details for the request? I probably miss it |
No problem. :)
After a brief discussion your team, we concluded that the rewriting stage should occur after calibration but before conversion. That's essentially the background. |