Add approximate gelu replacement to opt level 2 #10129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10129
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit a23d0c1 with merge base 4022ff1 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72935935 |
mcremon-meta
added a commit
that referenced
this pull request
Apr 14, 2025
Summary: As titled. Gelu is prohibitively expensive to run on DSPs, due to the std::erf call in the function. The PT approximate version using an approximation based on `tanh`, which is faster on the ASR encoder 27M model for example. Seems like BUCK files (even with just on_call commands, the linter is complaining). Differential Revision: D72935935
mcremon-meta
force-pushed
the
export-D72935935
branch
from
aa57c9e to
0b60121
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72935935 |
mcremon-meta
added a commit
that referenced
this pull request
Apr 14, 2025
Summary: Pull Request resolved: #10129 As titled. Gelu is prohibitively expensive to run on DSPs, due to the std::erf call in the function. The PT approximate version using an approximation based on `tanh`, which is faster on the ASR encoder 27M model for example. Seems like BUCK files (even with just on_call commands, the linter is complaining). Differential Revision: D72935935
mcremon-meta
force-pushed
the
export-D72935935
branch
from
0b60121 to
474a38c
Compare
mcremon-meta
added a commit
that referenced
this pull request
Apr 14, 2025
Summary: As titled. Gelu is prohibitively expensive to run on DSPs, due to the std::erf call in the function. The PT approximate version using an approximation based on `tanh`, which is faster on the ASR encoder 27M model for example. Seems like BUCK files (even with just on_call commands, the linter is complaining). Differential Revision: D72935935
mcremon-meta
force-pushed
the
export-D72935935
branch
from
474a38c to
108f90a
Compare
Summary: Pull Request resolved: #10129 As titled. Gelu is prohibitively expensive to run on DSPs, due to the std::erf call in the function. The PT approximate version using an approximation based on `tanh`, which is faster on the ASR encoder 27M model for example. Seems like BUCK files (even with just on_call commands, the linter is complaining). Differential Revision: D72935935
|
This pull request was exported from Phabricator. Differential Revision: D72935935 |
mcremon-meta
force-pushed
the
export-D72935935
branch
from
108f90a to
a23d0c1
Compare
zonglinpeng
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As titled. Gelu is prohibitively expensive to run on DSPs, due to the std::erf call in the function. The PT approximate version using an approximation based on
tanh, which is faster on the ASR encoder 27M model for example.Seems like BUCK files (even with just on_call commands, the linter is complaining).
Differential Revision: D72935935