Skip to content

[ET-VK] Reducing memory wastage by tightening DescriptorPoolConfig values. #10784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh/trivedivivek/84/base
Choose a base branch
from

Conversation

trivedivivek
Copy link
Contributor

@trivedivivek trivedivivek commented May 9, 2025

Stack from ghstack (oldest at bottom):

This change replaces std::max(descriptor_type_count, max_sets) with descriptor_type_count, when creating DescriptorPoolConfig in ComputeGraph since Vulkan does not need to have at least one of each descriptor_type_count per set.

Differential Revision: D74452971

…lues.

This change replaces std::max(*descriptor_type_count*, max_sets) with *descriptor_type_count*, when creating DescriptorPoolConfig in ComputeGraph since Vulkan does not need to have at least one of each *descriptor_type_count* per set.

Differential Revision: [D74452971](https://our.internmc.facebook.com/intern/diff/D74452971/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented May 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10784

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 39e8488 with merge base 277c39d (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 9, 2025
trivedivivek added a commit that referenced this pull request May 9, 2025
…lues.

This change replaces std::max(*descriptor_type_count*, max_sets) with *descriptor_type_count*, when creating DescriptorPoolConfig in ComputeGraph since Vulkan does not need to have at least one of each *descriptor_type_count* per set.

Differential Revision: [D74452971](https://our.internmc.facebook.com/intern/diff/D74452971/)

ghstack-source-id: 283034895
Pull Request resolved: #10784
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74452971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants