Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExecuTorch][XNNPACK] Don't partition per_tensor weights with qd8 #8891

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

digantdesai
Copy link
Contributor

@digantdesai digantdesai commented Mar 3, 2025

Stack from ghstack (oldest at bottom):

This is not supported, so we shouldn't partition it.

Add an expectedFailure test to indicate that this is not supported

Differential Revision: D70343584

This is not supported, so we shouldn't partition it.

Add an expectedFailure test to indicate that this is not supported

Differential Revision: [D70343584](https://our.internmc.facebook.com/intern/diff/D70343584/)

[ghstack-poisoned]
@digantdesai digantdesai requested a review from mcr229 as a code owner March 3, 2025 19:45
Copy link

pytorch-bot bot commented Mar 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8891

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ec4ce9f with merge base 542480c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70343584

@digantdesai digantdesai merged commit adcd607 into gh/digantdesai/19/base Mar 4, 2025
51 of 54 checks passed
@digantdesai digantdesai deleted the gh/digantdesai/19/head branch March 4, 2025 15:40
cccclai pushed a commit that referenced this pull request Mar 4, 2025
)

This is not supported, so we shouldn't partition it.

Add an expectedFailure test to indicate that this is not supported

Differential Revision: [D70343584](https://our.internmc.facebook.com/intern/diff/D70343584/)

ghstack-source-id: 269356867
Pull Request resolved: #8891

Co-authored-by: Digant Desai <[email protected]>
zonglinpeng pushed a commit that referenced this pull request Mar 6, 2025
)

This is not supported, so we shouldn't partition it.

Add an expectedFailure test to indicate that this is not supported

Differential Revision: [D70343584](https://our.internmc.facebook.com/intern/diff/D70343584/)

ghstack-source-id: 269356867
Pull Request resolved: #8891

Co-authored-by: Digant Desai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants