Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOCOMMIT: fail CI if ET_USE_THREADPOOL isn't defined where we think it should be #8948

Closed
wants to merge 25 commits into from
Closed

NOCOMMIT: fail CI if ET_USE_THREADPOOL isn't defined where we think it should be #8948

wants to merge 25 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 4, 2025 •
edited
Loading

No description provided.

swolchok added 6 commits March 4, 2025 11:35
@swolchok
Update
d0b11e8 
[ghstack-poisoned]
@swolchok
Update
9437be1 
[ghstack-poisoned]
@swolchok
Update
643e10e 
[ghstack-poisoned]
@swolchok
Update
6f2842b 
[ghstack-poisoned]
@swolchok
Update
e47dfeb 
[ghstack-poisoned]
@swolchok
Update
d4c7667 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 4, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8948

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d556c38 with merge base cca6917 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Mar 4, 2025
Merged
Merged
Merged
swolchok added a commit that referenced this pull request Mar 4, 2025
@swolchok
NOCOMMIT: fail CI if ET_USE_THREADPOOL isn't defined where we think i…
cb309fb 
…t should be

ghstack-source-id: 310b016fd96e8bf28c88308c27a6c6eddebda5fc
ghstack-comment-id: 2699165966
Pull Request resolved: #8948
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2025
@swolchok swolchok marked this pull request as draft March 4, 2025 22:57
swolchok added 4 commits March 4, 2025 18:23
@swolchok
Update
231ebc3 
[ghstack-poisoned]
@swolchok
Update
296513c 
[ghstack-poisoned]
@swolchok
Update
845a01e 
[ghstack-poisoned]
@swolchok
Update
9fdba71 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 5, 2025
@swolchok
NOCOMMIT: fail CI if ET_USE_THREADPOOL isn't defined where we think i…
0342a25 
…t should be

ghstack-source-id: 6d1de75a403ce76ac160389bca471d32916e39e6
ghstack-comment-id: 2699165966
Pull Request resolved: #8948
swolchok added 4 commits March 4, 2025 18:41
@swolchok
Update
a92958a 
[ghstack-poisoned]
@swolchok
Update
3fa99d6 
[ghstack-poisoned]
@swolchok
Update
a6c69a6 
[ghstack-poisoned]
@swolchok
Update
dddebe0 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 5, 2025
@swolchok
NOCOMMIT: fail CI if ET_USE_THREADPOOL isn't defined where we think i…
4d868fc 
…t should be

ghstack-source-id: 3cfa3acadb43b47a1c735ca095ea934b8acd1325
ghstack-comment-id: 2699165966
Pull Request resolved: #8948
@swolchok
Update
3bd6437 
[ghstack-poisoned]
swolchok added 3 commits March 4, 2025 19:54
@swolchok
Update
675f01b 
[ghstack-poisoned]
@swolchok
Update
5f3a768 
[ghstack-poisoned]
@swolchok
Update
6890f5e 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 5, 2025
@swolchok
NOCOMMIT: fail CI if ET_USE_THREADPOOL isn't defined where we think i…
349f645 
…t should be

ghstack-source-id: 20e8cefcb01cbef969e5348daa8d717ac5dd9cb8
ghstack-comment-id: 2699165966
Pull Request resolved: #8948
swolchok added 4 commits March 4, 2025 21:11
@swolchok
Update
9fdebee 
[ghstack-poisoned]
@swolchok
Update
70a7096 
[ghstack-poisoned]
@swolchok
Update
337dc23 
[ghstack-poisoned]
@swolchok
Update
6e6b318 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 5, 2025
@swolchok
NOCOMMIT: fail CI if ET_USE_THREADPOOL isn't defined where we think i…
b51302d 
…t should be

ghstack-source-id: 035e2dbd4ab3e791e5b9a1280f4c0e28f37abdc3
ghstack-comment-id: 2699165966
Pull Request resolved: #8948
swolchok added 3 commits March 5, 2025 10:55
@swolchok
Update
f388177 
[ghstack-poisoned]
@swolchok
Update
2949daf 
[ghstack-poisoned]
@swolchok
Update
d556c38 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 5, 2025
@swolchok
NOCOMMIT: fail CI if ET_USE_THREADPOOL isn't defined where we think i…
a6c79d0 
…t should be

ghstack-source-id: 0e62bffd6427db5e1b4b23ff3cece2f17f919c4c
ghstack-comment-id: 2699165966
Pull Request resolved: #8948
@swolchok
Copy link
Contributor Author

swolchok commented Mar 5, 2025

noting that CI is 100% green in case I rebase

Base automatically changed from gh/swolchok/308/head to main March 7, 2025 20:38
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Open
@swolchok swolchok closed this Mar 11, 2025
This was referenced Mar 17, 2025
Open
Open
@github-actions github-actions bot mentioned this pull request Mar 31, 2025
Open
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@iseeyuan iseeyuan Awaiting requested review from iseeyuan iseeyuan is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@kimishpatel kimishpatel Awaiting requested review from kimishpatel kimishpatel will be requested when the pull request is marked ready for review kimishpatel is a code owner

@GregoryComer GregoryComer Awaiting requested review from GregoryComer GregoryComer will be requested when the pull request is marked ready for review GregoryComer is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swolchok @facebook-github-bot