Don't repeatedly find_package(GTest) while running CMake #9146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9146
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 7f1ea55 with merge base d71f54a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Mar 11, 2025
This seems to improve cmake times by 6-10 seconds on my machine. ghstack-source-id: 530268d6ab52980aeb32722da98a0b86183009c6 ghstack-comment-id: 2715089715 Pull Request resolved: #9146
swolchok
added
the
release notes: build
mcr229
approved these changes
Mar 11, 2025
|
test failures are pretty clearly flakes, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to improve cmake times by 6-10 seconds on my machine.