Skip to content

[ExecuTorch] Add //examples/portable/executor_runner:executor_runner_opt #9291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 14, 2025

Stack from ghstack (oldest at bottom):

Attempt to add a Buck target that's analogous to the CMake build's executor_runner -- has all CPU ops that you need etc. The base executor_runner target is commented as intentionally having minimal deps, hence the separate target.

This is sort of a companion to #9248, except that that PR is for CMake only and this PR is for Buck only.

Differential Revision: D71220489

Attempt to add a Buck target that's analogous to the CMake build's executor_runner -- has all CPU ops that you need etc. The base executor_runner target is commented as intentionally having minimal deps, hence the separate target.

This is sort of a companion to #9248, except that that PR is for CMake only and this PR is for Buck only.

Differential Revision: [D71220489](https://our.internmc.facebook.com/intern/diff/D71220489/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Mar 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9291

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit a971482 with merge base a6cd1dc (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 14, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71220489

…tor_runner_opt"

Attempt to add a Buck target that's analogous to the CMake build's executor_runner -- has all CPU ops that you need etc. The base executor_runner target is commented as intentionally having minimal deps, hence the separate target.

This is sort of a companion to #9248, except that that PR is for CMake only and this PR is for Buck only.

Differential Revision: [D71220489](https://our.internmc.facebook.com/intern/diff/D71220489/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71220489

…tor_runner_opt"

Attempt to add a Buck target that's analogous to the CMake build's executor_runner -- has all CPU ops that you need etc. The base executor_runner target is commented as intentionally having minimal deps, hence the separate target.

This is sort of a companion to #9248, except that that PR is for CMake only and this PR is for Buck only.

Differential Revision: [D71220489](https://our.internmc.facebook.com/intern/diff/D71220489/)

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 21, 2025
Pull Request resolved: #9291

Attempt to add a Buck target that's analogous to the CMake build's executor_runner -- has all CPU ops that you need etc. The base executor_runner target is commented as intentionally having minimal deps, hence the separate target.

This is sort of a companion to #9248, except that that PR is for CMake only and this PR is for Buck only.
ghstack-source-id: 273335947
@exported-using-ghexport

Differential Revision: [D71220489](https://our.internmc.facebook.com/intern/diff/D71220489/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71220489

@swolchok
Copy link
Contributor Author

the following test failures look like known issues or flakes that are safe to ignore:

  • lintrunner
  • test-eval_llama-wikitext-linux
  • unittest-buck / macos

no other failures so far.

@swolchok swolchok merged commit 6aa9f5f into gh/swolchok/367/base Mar 21, 2025
78 of 82 checks passed
@swolchok swolchok deleted the gh/swolchok/367/head branch March 21, 2025 22:25
@swolchok swolchok temporarily deployed to cherry-pick-bot March 21, 2025 22:25 — with GitHub Actions Inactive
swolchok added a commit that referenced this pull request Mar 21, 2025
…opt (#9508)

This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #9291 by
@swolchok
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/swolchok/367/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/367/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/367/orig
@diff-train-skip-merge

Co-authored-by: Scott Wolchok <swolchok@meta.com>
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
…opt (pytorch#9508)

This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: pytorch#9291 by
@swolchok
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/swolchok/367/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/367/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/367/orig
@diff-train-skip-merge

Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants