Remove Per-Op mode from DQPartitioner #9378
Merged
+39
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D71427234](https://our.internmc.facebook.com/intern/diff/D71427234/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9378
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3ad960f with merge base 1300cda ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mcr229
added a commit
that referenced
this pull request
Mar 18, 2025
Differential Revision: [D71427234](https://our.internmc.facebook.com/intern/diff/D71427234/) ghstack-source-id: 272573375 Pull Request resolved: #9378
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71427234 |
Differential Revision: [D71427234](https://our.internmc.facebook.com/intern/diff/D71427234/) [ghstack-poisoned]
mcr229
added a commit
that referenced
this pull request
Mar 20, 2025
XNNPACK can handle Dynamically quantized partitions in which the dq chain is shared between two dynamic linear. This means per-op mode is not necessarily needed, and subsequently duplicate dynamic dequant is not needed. Pull Request resolved: #9378 Differential Revision: [D71427234](https://our.internmc.facebook.com/intern/diff/D71427234/) ghstack-source-id: 272885590
|
This pull request was exported from Phabricator. Differential Revision: D71427234 |
Differential Revision: [D71427234](https://our.internmc.facebook.com/intern/diff/D71427234/) [ghstack-poisoned]
mcr229
added a commit
that referenced
this pull request
Mar 20, 2025
XNNPACK can handle Dynamically quantized partitions in which the dq chain is shared between two dynamic linear. This means per-op mode is not necessarily needed, and subsequently duplicate dynamic dequant is not needed. Pull Request resolved: #9378 ghstack-source-id: 273077941 Differential Revision: [D71427234](https://our.internmc.facebook.com/intern/diff/D71427234/)
Differential Revision: [D71427234](https://our.internmc.facebook.com/intern/diff/D71427234/) [ghstack-poisoned]
mcr229
added a commit
that referenced
this pull request
Mar 20, 2025
XNNPACK can handle Dynamically quantized partitions in which the dq chain is shared between two dynamic linear. This means per-op mode is not necessarily needed, and subsequently duplicate dynamic dequant is not needed. Pull Request resolved: #9378 ghstack-source-id: 273078718 Differential Revision: [D71427234](https://our.internmc.facebook.com/intern/diff/D71427234/)
|
This pull request was exported from Phabricator. Differential Revision: D71427234 |
Differential Revision: [D71427234](https://our.internmc.facebook.com/intern/diff/D71427234/) [ghstack-poisoned]
mcr229
added a commit
that referenced
this pull request
Mar 20, 2025
XNNPACK can handle Dynamically quantized partitions in which the dq chain is shared between two dynamic linear. This means per-op mode is not necessarily needed, and subsequently duplicate dynamic dequant is not needed. Pull Request resolved: #9378 ghstack-source-id: 273122124 Differential Revision: [D71427234](https://our.internmc.facebook.com/intern/diff/D71427234/)
|
This pull request was exported from Phabricator. Differential Revision: D71427234 |
digantdesai
approved these changes
Mar 21, 2025
facebook-github-bot
merged commit 97fb7d6
into
gh/mcr229/14/base
80 of 82 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Mar 21, 2025
XNNPACK can handle Dynamically quantized partitions in which the dq chain is shared between two dynamic linear. This means per-op mode is not necessarily needed, and subsequently duplicate dynamic dequant is not needed. Pull Request resolved: #9378 ghstack-source-id: 273122124 Differential Revision: [D71427234](https://our.internmc.facebook.com/intern/diff/D71427234/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D71427234