Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] More flexibility in loading PettingZoo #1817

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

matteobettini
Copy link
Contributor

@matteobettini matteobettini commented Jan 19, 2024

This change is a PettingZoo change which is BC-compatible to all the pettingzoo versions we already supported.

In addition, in case pettingzoo cannot load all modules, it leverages the new PettingZoo 1.24.3 functionalities to load only group of environments

This ameliorates the issue Farama-Foundation/PettingZoo#1072

And fixes facebookresearch/BenchMARL#41

cc @elliottower

Copy link

pytorch-bot bot commented Jan 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1817

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 5 Unrelated Failures

As of commit 037f72a with merge base e98ee38 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 19, 2024
@matteobettini matteobettini changed the title [Feature] More flaxibility in loading PettingZoo [Feature] More flexibility in loading PettingZoo Jan 19, 2024
@vmoens vmoens added the enhancement New feature or request label Jan 19, 2024
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@vmoens vmoens merged commit a10cdbf into pytorch:main Jan 19, 2024
50 of 56 checks passed
@matteobettini matteobettini deleted the pettingzoo_fix branch January 19, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No module named 'pettingzoo.utils.all_modules'`
3 participants