Skip to content

[BugFix] Fix unique ref to lambda func #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vmoens wants to merge 1 commit into
base: gh/vmoens/168/base
Choose a base branch
from
Open

[BugFix] Fix unique ref to lambda func #3282

vmoens wants to merge 1 commit into from

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Dec 31, 2025 •
edited
Loading

@vmoens
Update
bc69265 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 31, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3282

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 10 Unrelated Failures

As of commit bc69265 with merge base 7866d11 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 31, 2025
This was referenced Dec 31, 2025
Open
Open
@github-actions
Copy link

github-actions bot commented Dec 31, 2025

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 164. Improved: $\large\color{#35bf28}26$. Worsened: $\large\color{#d91a1a}12$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_tensor_to_bytestream_speed[pickle] 83.2646μs 81.0785μs 12.3337 KOps/s 12.5687 KOps/s $\color{#d91a1a}-1.87\%$
test_tensor_to_bytestream_speed[torch.save] 0.1385ms 0.1373ms 7.2816 KOps/s 7.2805 KOps/s $\color{#35bf28}+0.02\%$
test_tensor_to_bytestream_speed[untyped_storage] 0.1182s 0.1134s 8.8182 Ops/s 8.4513 Ops/s $\color{#35bf28}+4.34\%$
test_tensor_to_bytestream_speed[numpy] 2.6863μs 2.6785μs 373.3427 KOps/s 369.8396 KOps/s $\color{#35bf28}+0.95\%$
test_tensor_to_bytestream_speed[safetensors] 38.8475μs 37.5523μs 26.6295 KOps/s 27.4245 KOps/s $\color{#d91a1a}-2.90\%$
test_simple 0.5334s 0.5328s 1.8767 Ops/s 1.7778 Ops/s $\textbf{\color{#35bf28}+5.57\%}$
test_transformed 1.0970s 1.0953s 0.9130 Ops/s 0.8855 Ops/s $\color{#35bf28}+3.11\%$
test_serial 1.6283s 1.6269s 0.6147 Ops/s 0.6012 Ops/s $\color{#35bf28}+2.23\%$
test_parallel 1.0889s 1.0697s 0.9349 Ops/s 0.8759 Ops/s $\textbf{\color{#35bf28}+6.73\%}$
test_step_mdp_speed[True-True-True-True-True] 0.1938ms 43.0854μs 23.2097 KOps/s 23.5132 KOps/s $\color{#d91a1a}-1.29\%$
test_step_mdp_speed[True-True-True-True-False] 59.6610μs 24.4744μs 40.8590 KOps/s 41.1575 KOps/s $\color{#d91a1a}-0.73\%$
test_step_mdp_speed[True-True-True-False-True] 49.1800μs 24.4728μs 40.8618 KOps/s 40.3129 KOps/s $\color{#35bf28}+1.36\%$
test_step_mdp_speed[True-True-True-False-False] 42.7010μs 13.6323μs 73.3553 KOps/s 74.6944 KOps/s $\color{#d91a1a}-1.79\%$
test_step_mdp_speed[True-True-False-True-True] 71.7410μs 47.3626μs 21.1137 KOps/s 21.5275 KOps/s $\color{#d91a1a}-1.92\%$
test_step_mdp_speed[True-True-False-True-False] 0.1015ms 27.2693μs 36.6712 KOps/s 37.0305 KOps/s $\color{#d91a1a}-0.97\%$
test_step_mdp_speed[True-True-False-False-True] 59.6010μs 27.8307μs 35.9315 KOps/s 36.2267 KOps/s $\color{#d91a1a}-0.81\%$
test_step_mdp_speed[True-True-False-False-False] 42.6010μs 16.5184μs 60.5385 KOps/s 61.7085 KOps/s $\color{#d91a1a}-1.90\%$
test_step_mdp_speed[True-False-True-True-True] 83.7110μs 50.1144μs 19.9543 KOps/s 20.2848 KOps/s $\color{#d91a1a}-1.63\%$
test_step_mdp_speed[True-False-True-True-False] 63.2510μs 30.5410μs 32.7428 KOps/s 33.4048 KOps/s $\color{#d91a1a}-1.98\%$
test_step_mdp_speed[True-False-True-False-True] 64.3410μs 27.4450μs 36.4365 KOps/s 37.3297 KOps/s $\color{#d91a1a}-2.39\%$
test_step_mdp_speed[True-False-True-False-False] 45.1810μs 16.3926μs 61.0030 KOps/s 62.2367 KOps/s $\color{#d91a1a}-1.98\%$
test_step_mdp_speed[True-False-False-True-True] 92.8410μs 52.2048μs 19.1553 KOps/s 19.3696 KOps/s $\color{#d91a1a}-1.11\%$
test_step_mdp_speed[True-False-False-True-False] 65.6610μs 32.5236μs 30.7469 KOps/s 31.2890 KOps/s $\color{#d91a1a}-1.73\%$
test_step_mdp_speed[True-False-False-False-True] 63.7010μs 29.2532μs 34.1843 KOps/s 34.0737 KOps/s $\color{#35bf28}+0.32\%$
test_step_mdp_speed[True-False-False-False-False] 58.2900μs 19.4519μs 51.4089 KOps/s 53.6000 KOps/s $\color{#d91a1a}-4.09\%$
test_step_mdp_speed[False-True-True-True-True] 81.2410μs 50.2558μs 19.8982 KOps/s 20.3656 KOps/s $\color{#d91a1a}-2.30\%$
test_step_mdp_speed[False-True-True-True-False] 82.6910μs 30.3548μs 32.9437 KOps/s 33.2301 KOps/s $\color{#d91a1a}-0.86\%$
test_step_mdp_speed[False-True-True-False-True] 2.4229ms 32.5853μs 30.6887 KOps/s 32.2221 KOps/s $\color{#d91a1a}-4.76\%$
test_step_mdp_speed[False-True-True-False-False] 52.9210μs 18.5238μs 53.9846 KOps/s 55.7699 KOps/s $\color{#d91a1a}-3.20\%$
test_step_mdp_speed[False-True-False-True-True] 91.5620μs 52.9984μs 18.8685 KOps/s 19.3216 KOps/s $\color{#d91a1a}-2.35\%$
test_step_mdp_speed[False-True-False-True-False] 72.2210μs 33.4869μs 29.8625 KOps/s 30.5644 KOps/s $\color{#d91a1a}-2.30\%$
test_step_mdp_speed[False-True-False-False-True] 73.8910μs 35.1816μs 28.4240 KOps/s 30.0318 KOps/s $\textbf{\color{#d91a1a}-5.35\%}$
test_step_mdp_speed[False-True-False-False-False] 51.4810μs 21.1789μs 47.2169 KOps/s 48.6023 KOps/s $\color{#d91a1a}-2.85\%$
test_step_mdp_speed[False-False-True-True-True] 92.9120μs 56.1326μs 17.8150 KOps/s 18.2970 KOps/s $\color{#d91a1a}-2.63\%$
test_step_mdp_speed[False-False-True-True-False] 78.6910μs 35.7778μs 27.9503 KOps/s 28.1442 KOps/s $\color{#d91a1a}-0.69\%$
test_step_mdp_speed[False-False-True-False-True] 67.5810μs 33.2930μs 30.0363 KOps/s 30.2233 KOps/s $\color{#d91a1a}-0.62\%$
test_step_mdp_speed[False-False-True-False-False] 52.9010μs 20.6717μs 48.3752 KOps/s 48.6507 KOps/s $\color{#d91a1a}-0.57\%$
test_step_mdp_speed[False-False-False-True-True] 89.7820μs 56.2291μs 17.7844 KOps/s 17.6639 KOps/s $\color{#35bf28}+0.68\%$
test_step_mdp_speed[False-False-False-True-False] 66.3610μs 37.6668μs 26.5485 KOps/s 26.3579 KOps/s $\color{#35bf28}+0.72\%$
test_step_mdp_speed[False-False-False-False-True] 67.9610μs 34.8978μs 28.6551 KOps/s 28.1137 KOps/s $\color{#35bf28}+1.93\%$
test_step_mdp_speed[False-False-False-False-False] 53.2410μs 22.7968μs 43.8657 KOps/s 44.8102 KOps/s $\color{#d91a1a}-2.11\%$
test_non_tensor_env_rollout_speed[1000-single-True] 0.8781s 0.7913s 1.2637 Ops/s 1.3052 Ops/s $\color{#d91a1a}-3.18\%$
test_non_tensor_env_rollout_speed[1000-single-False] 0.7249s 0.6477s 1.5438 Ops/s 1.5916 Ops/s $\color{#d91a1a}-3.00\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-True] 1.7606s 1.6827s 0.5943 Ops/s 0.5962 Ops/s $\color{#d91a1a}-0.33\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-False] 1.5346s 1.4561s 0.6868 Ops/s 0.6885 Ops/s $\color{#d91a1a}-0.25\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-True] 1.9834s 1.9017s 0.5258 Ops/s 0.5206 Ops/s $\color{#35bf28}+1.01\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-False] 1.7639s 1.6815s 0.5947 Ops/s 0.5898 Ops/s $\color{#35bf28}+0.83\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-True] 4.7415s 4.5717s 0.2187 Ops/s 0.2165 Ops/s $\color{#35bf28}+1.02\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-False] 4.7137s 4.4251s 0.2260 Ops/s 0.2252 Ops/s $\color{#35bf28}+0.36\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-True] 2.0212s 1.9497s 0.5129 Ops/s 0.5061 Ops/s $\color{#35bf28}+1.35\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-False] 1.7330s 1.6632s 0.6013 Ops/s 0.5906 Ops/s $\color{#35bf28}+1.80\%$
test_values[generalized_advantage_estimate-True-True] 10.1834ms 9.8605ms 101.4150 Ops/s 95.5382 Ops/s $\textbf{\color{#35bf28}+6.15\%}$
test_values[vec_generalized_advantage_estimate-True-True] 19.2604ms 17.9274ms 55.7806 Ops/s 85.8489 Ops/s $\textbf{\color{#d91a1a}-35.02\%}$
test_values[td0_return_estimate-False-False] 0.2259ms 0.1299ms 7.7009 KOps/s 7.6570 KOps/s $\color{#35bf28}+0.57\%$
test_values[td1_return_estimate-False-False] 27.4543ms 26.9230ms 37.1430 Ops/s 35.5535 Ops/s $\color{#35bf28}+4.47\%$
test_values[vec_td1_return_estimate-False-False] 19.2333ms 17.9629ms 55.6703 Ops/s 87.3460 Ops/s $\textbf{\color{#d91a1a}-36.26\%}$
test_values[td_lambda_return_estimate-True-False] 40.2302ms 39.5752ms 25.2684 Ops/s 24.1131 Ops/s $\color{#35bf28}+4.79\%$
test_values[vec_td_lambda_return_estimate-True-False] 19.1008ms 17.9886ms 55.5909 Ops/s 88.0997 Ops/s $\textbf{\color{#d91a1a}-36.90\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.0539ms 8.7410ms 114.4028 Ops/s 108.3340 Ops/s $\textbf{\color{#35bf28}+5.60\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.6954ms 1.5083ms 663.0027 Ops/s 666.3363 Ops/s $\color{#d91a1a}-0.50\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5397ms 0.4095ms 2.4423 KOps/s 2.4012 KOps/s $\color{#35bf28}+1.71\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 36.5505ms 33.2188ms 30.1035 Ops/s 33.4069 Ops/s $\textbf{\color{#d91a1a}-9.89\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 2.1377ms 1.7935ms 557.5802 Ops/s 551.8495 Ops/s $\color{#35bf28}+1.04\%$
test_dqn_speed[False-None] 1.6546ms 1.3959ms 716.3882 Ops/s 720.7561 Ops/s $\color{#d91a1a}-0.61\%$
test_dqn_speed[False-backward] 2.0196ms 1.8977ms 526.9617 Ops/s 527.0653 Ops/s $\color{#d91a1a}-0.02\%$
test_dqn_speed[True-None] 0.7519ms 0.5264ms 1.8998 KOps/s 1.8934 KOps/s $\color{#35bf28}+0.34\%$
test_dqn_speed[True-backward] 0.9833ms 0.9526ms 1.0497 KOps/s 1.0138 KOps/s $\color{#35bf28}+3.54\%$
test_dqn_speed[reduce-overhead-None] 0.9176ms 0.5187ms 1.9278 KOps/s 1.8760 KOps/s $\color{#35bf28}+2.76\%$
test_dqn_speed[reduce-overhead-backward] 1.0039ms 0.9460ms 1.0571 KOps/s 950.4787 Ops/s $\textbf{\color{#35bf28}+11.22\%}$
test_ddpg_speed[False-None] 3.1504ms 2.8256ms 353.9095 Ops/s 355.9047 Ops/s $\color{#d91a1a}-0.56\%$
test_ddpg_speed[False-backward] 4.1097ms 4.0252ms 248.4379 Ops/s 244.2047 Ops/s $\color{#35bf28}+1.73\%$
test_ddpg_speed[True-None] 1.4179ms 1.3585ms 736.1183 Ops/s 712.4609 Ops/s $\color{#35bf28}+3.32\%$
test_ddpg_speed[True-backward] 2.3458ms 2.3072ms 433.4225 Ops/s 381.0944 Ops/s $\textbf{\color{#35bf28}+13.73\%}$
test_ddpg_speed[reduce-overhead-None] 1.5009ms 1.3617ms 734.3664 Ops/s 729.6715 Ops/s $\color{#35bf28}+0.64\%$
test_ddpg_speed[reduce-overhead-backward] 2.3390ms 2.2819ms 438.2352 Ops/s 384.9346 Ops/s $\textbf{\color{#35bf28}+13.85\%}$
test_sac_speed[False-None] 8.1956ms 7.7825ms 128.4941 Ops/s 125.6537 Ops/s $\color{#35bf28}+2.26\%$
test_sac_speed[False-backward] 11.5293ms 11.0029ms 90.8853 Ops/s 88.6814 Ops/s $\color{#35bf28}+2.49\%$
test_sac_speed[True-None] 2.1675ms 2.0691ms 483.3082 Ops/s 461.1520 Ops/s $\color{#35bf28}+4.80\%$
test_sac_speed[True-backward] 4.1750ms 3.8732ms 258.1833 Ops/s 227.0541 Ops/s $\textbf{\color{#35bf28}+13.71\%}$
test_sac_speed[reduce-overhead-None] 2.1743ms 2.0600ms 485.4424 Ops/s 467.1237 Ops/s $\color{#35bf28}+3.92\%$
test_sac_speed[reduce-overhead-backward] 4.0372ms 3.8996ms 256.4333 Ops/s 229.2756 Ops/s $\textbf{\color{#35bf28}+11.85\%}$
test_redq_speed[False-None] 14.7533ms 10.3983ms 96.1700 Ops/s 98.0873 Ops/s $\color{#d91a1a}-1.95\%$
test_redq_speed[False-backward] 23.0130ms 17.7180ms 56.4399 Ops/s 57.2745 Ops/s $\color{#d91a1a}-1.46\%$
test_redq_speed[True-None] 4.5700ms 4.2399ms 235.8520 Ops/s 232.4033 Ops/s $\color{#35bf28}+1.48\%$
test_redq_speed[True-backward] 9.6088ms 9.3520ms 106.9291 Ops/s 107.3487 Ops/s $\color{#d91a1a}-0.39\%$
test_redq_speed[reduce-overhead-None] 4.9899ms 4.1340ms 241.8968 Ops/s 225.9809 Ops/s $\textbf{\color{#35bf28}+7.04\%}$
test_redq_speed[reduce-overhead-backward] 9.7465ms 9.5064ms 105.1923 Ops/s 101.6036 Ops/s $\color{#35bf28}+3.53\%$
test_redq_deprec_speed[False-None] 12.2951ms 10.8941ms 91.7925 Ops/s 90.5778 Ops/s $\color{#35bf28}+1.34\%$
test_redq_deprec_speed[False-backward] 15.9405ms 15.6219ms 64.0125 Ops/s 62.8879 Ops/s $\color{#35bf28}+1.79\%$
test_redq_deprec_speed[True-None] 4.0029ms 3.5594ms 280.9469 Ops/s 264.5591 Ops/s $\textbf{\color{#35bf28}+6.19\%}$
test_redq_deprec_speed[True-backward] 10.3668ms 7.8388ms 127.5698 Ops/s 123.7899 Ops/s $\color{#35bf28}+3.05\%$
test_redq_deprec_speed[reduce-overhead-None] 4.0281ms 3.6136ms 276.7338 Ops/s 277.7468 Ops/s $\color{#d91a1a}-0.36\%$
test_redq_deprec_speed[reduce-overhead-backward] 7.7751ms 7.5464ms 132.5140 Ops/s 127.4510 Ops/s $\color{#35bf28}+3.97\%$
test_td3_speed[False-None] 7.9179ms 7.8627ms 127.1832 Ops/s 125.8526 Ops/s $\color{#35bf28}+1.06\%$
test_td3_speed[False-backward] 11.1963ms 10.7123ms 93.3504 Ops/s 92.0504 Ops/s $\color{#35bf28}+1.41\%$
test_td3_speed[True-None] 1.9969ms 1.7495ms 571.5915 Ops/s 551.2288 Ops/s $\color{#35bf28}+3.69\%$
test_td3_speed[True-backward] 3.6573ms 3.5453ms 282.0618 Ops/s 229.0420 Ops/s $\textbf{\color{#35bf28}+23.15\%}$
test_td3_speed[reduce-overhead-None] 1.7666ms 1.7192ms 581.6742 Ops/s 568.3227 Ops/s $\color{#35bf28}+2.35\%$
test_td3_speed[reduce-overhead-backward] 3.6177ms 3.5202ms 284.0742 Ops/s 279.5239 Ops/s $\color{#35bf28}+1.63\%$
test_cql_speed[False-None] 28.5388ms 25.5707ms 39.1072 Ops/s 38.3928 Ops/s $\color{#35bf28}+1.86\%$
test_cql_speed[False-backward] 35.1737ms 34.3239ms 29.1342 Ops/s 28.3746 Ops/s $\color{#35bf28}+2.68\%$
test_cql_speed[True-None] 12.3146ms 12.1168ms 82.5302 Ops/s 81.8174 Ops/s $\color{#35bf28}+0.87\%$
test_cql_speed[True-backward] 17.7846ms 17.3528ms 57.6276 Ops/s 55.6724 Ops/s $\color{#35bf28}+3.51\%$
test_cql_speed[reduce-overhead-None] 12.6446ms 12.3020ms 81.2878 Ops/s 81.5626 Ops/s $\color{#d91a1a}-0.34\%$
test_cql_speed[reduce-overhead-backward] 17.8749ms 17.4633ms 57.2630 Ops/s 55.2618 Ops/s $\color{#35bf28}+3.62\%$
test_a2c_speed[False-None] 5.4188ms 5.2490ms 190.5111 Ops/s 184.3047 Ops/s $\color{#35bf28}+3.37\%$
test_a2c_speed[False-backward] 11.9280ms 11.5913ms 86.2719 Ops/s 84.0254 Ops/s $\color{#35bf28}+2.67\%$
test_a2c_speed[True-None] 3.8021ms 3.6206ms 276.2000 Ops/s 265.7536 Ops/s $\color{#35bf28}+3.93\%$
test_a2c_speed[True-backward] 9.5889ms 8.5091ms 117.5206 Ops/s 114.6916 Ops/s $\color{#35bf28}+2.47\%$
test_a2c_speed[reduce-overhead-None] 3.7939ms 3.6510ms 273.8983 Ops/s 272.2035 Ops/s $\color{#35bf28}+0.62\%$
test_a2c_speed[reduce-overhead-backward] 8.8554ms 8.6110ms 116.1306 Ops/s 111.4453 Ops/s $\color{#35bf28}+4.20\%$
test_ppo_speed[False-None] 5.9212ms 5.7320ms 174.4604 Ops/s 171.7415 Ops/s $\color{#35bf28}+1.58\%$
test_ppo_speed[False-backward] 12.3764ms 12.0061ms 83.2908 Ops/s 80.8117 Ops/s $\color{#35bf28}+3.07\%$
test_ppo_speed[True-None] 3.6756ms 3.5535ms 281.4098 Ops/s 274.2768 Ops/s $\color{#35bf28}+2.60\%$
test_ppo_speed[True-backward] 8.4199ms 8.1203ms 123.1479 Ops/s 114.4856 Ops/s $\textbf{\color{#35bf28}+7.57\%}$
test_ppo_speed[reduce-overhead-None] 3.7004ms 3.5376ms 282.6740 Ops/s 280.6993 Ops/s $\color{#35bf28}+0.70\%$
test_ppo_speed[reduce-overhead-backward] 8.7653ms 8.5577ms 116.8532 Ops/s 114.3856 Ops/s $\color{#35bf28}+2.16\%$
test_reinforce_speed[False-None] 4.7250ms 4.4834ms 223.0463 Ops/s 218.8590 Ops/s $\color{#35bf28}+1.91\%$
test_reinforce_speed[False-backward] 7.6776ms 7.2787ms 137.3867 Ops/s 136.6792 Ops/s $\color{#35bf28}+0.52\%$
test_reinforce_speed[True-None] 3.0176ms 2.7861ms 358.9184 Ops/s 328.4375 Ops/s $\textbf{\color{#35bf28}+9.28\%}$
test_reinforce_speed[True-backward] 7.6913ms 7.5390ms 132.6440 Ops/s 128.6268 Ops/s $\color{#35bf28}+3.12\%$
test_reinforce_speed[reduce-overhead-None] 3.0550ms 2.7595ms 362.3799 Ops/s 340.2954 Ops/s $\textbf{\color{#35bf28}+6.49\%}$
test_reinforce_speed[reduce-overhead-backward] 8.0852ms 7.7574ms 128.9094 Ops/s 114.2056 Ops/s $\textbf{\color{#35bf28}+12.87\%}$
test_iql_speed[False-None] 20.2691ms 19.7627ms 50.6005 Ops/s 49.1438 Ops/s $\color{#35bf28}+2.96\%$
test_iql_speed[False-backward] 30.2344ms 29.8222ms 33.5321 Ops/s 32.8107 Ops/s $\color{#35bf28}+2.20\%$
test_iql_speed[True-None] 8.7120ms 8.3651ms 119.5444 Ops/s 116.2150 Ops/s $\color{#35bf28}+2.86\%$
test_iql_speed[True-backward] 16.6609ms 16.3526ms 61.1522 Ops/s 60.8106 Ops/s $\color{#35bf28}+0.56\%$
test_iql_speed[reduce-overhead-None] 8.7848ms 8.4232ms 118.7200 Ops/s 116.6223 Ops/s $\color{#35bf28}+1.80\%$
test_iql_speed[reduce-overhead-backward] 17.1779ms 16.8614ms 59.3069 Ops/s 58.5478 Ops/s $\color{#35bf28}+1.30\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.3764ms 5.8709ms 170.3314 Ops/s 169.1160 Ops/s $\color{#35bf28}+0.72\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.4996ms 0.2794ms 3.5791 KOps/s 3.4474 KOps/s $\color{#35bf28}+3.82\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.4566ms 0.2568ms 3.8943 KOps/s 3.4686 KOps/s $\textbf{\color{#35bf28}+12.27\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.8376ms 5.5955ms 178.7154 Ops/s 177.9501 Ops/s $\color{#35bf28}+0.43\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.7499ms 0.2718ms 3.6794 KOps/s 3.3233 KOps/s $\textbf{\color{#35bf28}+10.72\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.4683ms 0.2549ms 3.9230 KOps/s 2.9864 KOps/s $\textbf{\color{#35bf28}+31.36\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.4090ms 1.2246ms 816.6255 Ops/s 720.4518 Ops/s $\textbf{\color{#35bf28}+13.35\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.3548ms 1.1429ms 874.9805 Ops/s 760.3342 Ops/s $\textbf{\color{#35bf28}+15.08\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 8.9043ms 5.8271ms 171.6121 Ops/s 174.3346 Ops/s $\color{#d91a1a}-1.56\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0463ms 0.4193ms 2.3848 KOps/s 1.0683 KOps/s $\textbf{\color{#35bf28}+123.25\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6361ms 0.3997ms 2.5016 KOps/s 2.4325 KOps/s $\color{#35bf28}+2.84\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.7260ms 5.6192ms 177.9610 Ops/s 176.6351 Ops/s $\color{#35bf28}+0.75\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0308ms 0.2842ms 3.5182 KOps/s 3.5566 KOps/s $\color{#d91a1a}-1.08\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.4715ms 0.2859ms 3.4976 KOps/s 3.7964 KOps/s $\textbf{\color{#d91a1a}-7.87\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.7310ms 5.5374ms 180.5885 Ops/s 177.9874 Ops/s $\color{#35bf28}+1.46\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9402ms 0.2918ms 3.4275 KOps/s 3.5814 KOps/s $\color{#d91a1a}-4.30\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.4849ms 0.2780ms 3.5969 KOps/s 3.8113 KOps/s $\textbf{\color{#d91a1a}-5.62\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.1327ms 5.7331ms 174.4262 Ops/s 171.0553 Ops/s $\color{#35bf28}+1.97\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9087ms 0.5054ms 1.9787 KOps/s 2.2259 KOps/s $\textbf{\color{#d91a1a}-11.10\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7015ms 0.4670ms 2.1414 KOps/s 2.4167 KOps/s $\textbf{\color{#d91a1a}-11.39\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.6595s 18.0346ms 55.4488 Ops/s 197.1899 Ops/s $\textbf{\color{#d91a1a}-71.88\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 10.9193ms 2.1044ms 475.1992 Ops/s 434.7429 Ops/s $\textbf{\color{#35bf28}+9.31\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.2587ms 1.0564ms 946.6025 Ops/s 821.2703 Ops/s $\textbf{\color{#35bf28}+15.26\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 8.3029ms 4.9600ms 201.6120 Ops/s 52.7892 Ops/s $\textbf{\color{#35bf28}+281.92\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 6.4159ms 2.0041ms 498.9811 Ops/s 557.5077 Ops/s $\textbf{\color{#d91a1a}-10.50\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 8.7944ms 1.2479ms 801.3156 Ops/s 781.6115 Ops/s $\color{#35bf28}+2.52\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.5751s 16.6366ms 60.1085 Ops/s 190.4442 Ops/s $\textbf{\color{#d91a1a}-68.44\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 9.4635ms 2.1290ms 469.7099 Ops/s 454.8332 Ops/s $\color{#35bf28}+3.27\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.0930ms 0.9903ms 1.0098 KOps/s 721.9104 Ops/s $\textbf{\color{#35bf28}+39.88\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 37.7052ms 33.2586ms 30.0674 Ops/s 29.4835 Ops/s $\color{#35bf28}+1.98\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 19.1232ms 17.2075ms 58.1143 Ops/s 56.5591 Ops/s $\color{#35bf28}+2.75\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 36.1834ms 34.0409ms 29.3764 Ops/s 28.5116 Ops/s $\color{#35bf28}+3.03\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 19.0142ms 17.5406ms 57.0106 Ops/s 56.0379 Ops/s $\color{#35bf28}+1.74\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 37.5468ms 35.7001ms 28.0111 Ops/s 27.0215 Ops/s $\color{#35bf28}+3.66\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 20.2862ms 18.8584ms 53.0267 Ops/s 51.2634 Ops/s $\color{#35bf28}+3.44\%$

This was referenced Dec 31, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoens