Make torchserve-kfs docker image multiplatform #3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d amd platforms, this command also pushes the image, it can not be loaded into the local registry due to limitations in buildx Also update build_upload_release.py and docker_nightly.py so docker images do not need to be pushed separately
DanielTemesgen
commented
May 25, 2024
| @@ -57,4 +57,5 @@ fi | |||
| cp ../../frontend/server/src/main/resources/proto/*.proto . | |||
| cp -r ../../third_party . | |||
|
|
|||
| DOCKER_BUILDKIT=1 docker build --file "$DOCKER_FILE" --build-arg BASE_IMAGE=$BASE_IMAGE -t "$DOCKER_TAG" . | |||
| docker buildx create --name mybuilder --use --bootstrap | |||
| docker buildx build --file "$DOCKER_FILE" --build-arg BASE_IMAGE=$BASE_IMAGE --platform linux/amd64,linux/arm64 --push -t "$DOCKER_TAG" . | |||
There was a problem hiding this comment.
This command builds and pushes the docker image, so the steps in both python files which push the image have been removed.
|
Hi @agunapal! Would you be able to approve the workflows for this please? |
Hi @DanielTemesgen This would need a discussion. If we publish a new artifact, then we also need to sign up for testing/maintaining it. The kserve nightly test would also need to change to test the new platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does the following:
Please read our CONTRIBUTING.md prior to creating your first pull request.
Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #3161
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Built image locally, pushed here.
Checklist: