Skip to content

Split samplers implementation across different files #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2024
Merged

Split samplers implementation across different files #259

merged 3 commits into from
Oct 11, 2024

Conversation

NicolasHug
Copy link
Member

This PR splits the existing _implem.py file into:

  • _time_based.py
  • _index_based.py
  • _common.py

The policy-related tests are also extracted into a separate test_policy file.

Zero logic was changed. Only copy/pasting.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 11, 2024
ahmadsharif1
ahmadsharif1 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@ahmadsharif1 ahmadsharif1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming 0 actual changes

@NicolasHug NicolasHug merged commit ea1ad0f into pytorch:main Oct 11, 2024
21 of 22 checks passed
@NicolasHug NicolasHug deleted the samplers_refac branch October 11, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadsharif1 ahmadsharif1 ahmadsharif1 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @ahmadsharif1 @facebook-github-bot