Skip to content

Fix cuda builds for lower than 6.1 ffmpeg versions #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

ahmadsharif1
Copy link
Contributor

@ahmadsharif1 ahmadsharif1 commented Oct 17, 2024

Previously we were always compiling code that contained a macro introduced in a new ffmpeg version. That would fail because that macro was not defined.

This change guards getFFMPEGContextFromExistingCudaContext for older libavutil versions because it contains a macro that's introduced in FFMPEG 6 onwards.

Also add more builders for different ffmpeg versions

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 17, 2024
@ahmadsharif1 ahmadsharif1 changed the title Fix cuda builds for lower ffmpeg versions Fix cuda builds for lower than 6.1 ffmpeg versions Oct 17, 2024
@scotts
Copy link
Contributor

scotts commented Oct 17, 2024

Approving to unblock because we have builds breaking, but we want to refactor this logic so it's more obviously the correct thing. That is, we would ideally do this kind of macro check once, not in several places.

@ahmadsharif1 ahmadsharif1 merged commit c4d6342 into pytorch:main Oct 17, 2024
24 checks passed
@ahmadsharif1 ahmadsharif1 deleted the cuda9 branch October 17, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants