Add debugging instructions for "Reproducibility between runs" #1363
+58
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
tianyu-l
reviewed
Jul 2, 2025
docs/debugging.md
Outdated
| - **Data Parallel (DP/FSDP):** All ranks use the same seed for model initialization | ||
| - **Tensor Parallel (TP):** All TP ranks use the same seed for consistent weight sharding | ||
| - **Pipeline Parallel (PP):** Each PP stage gets a different seed to ensure different dropout patterns | ||
| - **Sequence Parallel:** Maintains consistent seeding across sequence-sharded dimensions |
There was a problem hiding this comment.
what's this? CP?
If so, for parameters, dp_shard mesh and cp mesh together form the FSDP sharding group. So if dp_shard=2, cp=2, the parameter sharding are the same as dp_shard=4, cp=1.
Co-authored-by: tianyu-l <[email protected]>
Co-authored-by: tianyu-l <[email protected]>
Co-authored-by: tianyu-l <[email protected]>
tianyu-l
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled. To avoid someone with the same issue as me to understand why we need "seed checkpoint"