[Not for landing] piggy back on titan for scale init test #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
fduwjj
added a commit
that referenced
this pull request
Feb 13, 2025
ghstack-source-id: 8e8b5d5aab718d22305b61c98873b4da9872abe7 Pull Request resolved: #841
facebook-github-bot
added
the
CLA Signed
[ghstack-poisoned]
fduwjj
added a commit
that referenced
this pull request
Feb 13, 2025
ghstack-source-id: 8852e63604fc363c10327b8cd997a5a40c3a7533 Pull Request resolved: #841
[ghstack-poisoned]
fduwjj
added a commit
that referenced
this pull request
Feb 13, 2025
ghstack-source-id: 1199eaf906caf29d623ec9c616f5ce8a687b3427 Pull Request resolved: #841
[ghstack-poisoned]
fduwjj
added a commit
that referenced
this pull request
Feb 13, 2025
ghstack-source-id: a009c10ce7188bafaa29c9c7594e64c664ae8566 Pull Request resolved: #841
[ghstack-poisoned]
fduwjj
added a commit
that referenced
this pull request
Feb 14, 2025
ghstack-source-id: 6b41f54a558d605976f502e04d4968eb6f10a2a7 Pull Request resolved: #841
|
Can you run an all-reduce on |
|
We are doing post-processing anyway. so I don't think all-reduce is needed. Plus by the time, there is no PG already. |
[ghstack-poisoned]
fduwjj
added a commit
that referenced
this pull request
Mar 3, 2025
ghstack-source-id: c6a5b0d8f912999a10d7bf43e17ebf7bd11348d4 Pull Request resolved: #841
[ghstack-poisoned]
fduwjj
added a commit
that referenced
this pull request
Mar 3, 2025
ghstack-source-id: f11a19b5ceab133bf10d3e592c463c7292e91e17 Pull Request resolved: #841
[ghstack-poisoned]
fduwjj
added a commit
that referenced
this pull request
Mar 3, 2025
ghstack-source-id: 1a2c6661ba9894fe2ccc5a895a3abb46c478acdc Pull Request resolved: #841
[ghstack-poisoned]
fduwjj
added a commit
that referenced
this pull request
Mar 3, 2025
ghstack-source-id: 0b551fed8c01c2da316a4448d7dced9c6e598777 Pull Request resolved: #841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):