(torchx/scheduler) Fill hostnames for each replica in slurm scheduler's describe API #1080

kiukchung · 2025-06-12T03:33:37Z

Summary: Use scontrol to implement the describe API that fills out the hostnames for each replica.

Differential Revision: D76485112

facebook-github-bot · 2025-06-12T03:33:47Z

This pull request was exported from Phabricator. Differential Revision: D76485112

torchx/schedulers/slurm_scheduler.py

…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Differential Revision: D76485112

facebook-github-bot · 2025-06-12T21:02:47Z

This pull request was exported from Phabricator. Differential Revision: D76485112

d4l3k

LGTM

d4l3k · 2025-06-12T21:12:37Z

torchx/schedulers/slurm_scheduler.py


        return DescribeAppResponse(
            app_id=app_id,
            roles=list(roles.values()),
            roles_statuses=list(roles_statuses.values()),
-            state=app_state,
-            msg=msg,


msg isn't needed?

yea msg defaults to an empty string if not specified. We were just setting msg=state so no real functional value added + describe_sacct didn't set msg

…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112

facebook-github-bot · 2025-06-12T22:11:54Z

This pull request was exported from Phabricator. Differential Revision: D76485112

facebook-github-bot · 2025-06-12T22:13:25Z

This pull request was exported from Phabricator. Differential Revision: D76485112

…'s describe API (#1080) Summary: Pull Request resolved: #1080 Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112

facebook-github-bot · 2025-06-12T23:32:53Z

This pull request was exported from Phabricator. Differential Revision: D76485112

…'s describe API (#1080) Summary: Pull Request resolved: #1080 Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112

facebook-github-bot · 2025-06-13T00:06:11Z

This pull request was exported from Phabricator. Differential Revision: D76485112

…'s describe API (#1080) Summary: Pull Request resolved: #1080 Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112

facebook-github-bot · 2025-06-13T00:12:31Z

This pull request was exported from Phabricator. Differential Revision: D76485112

…'s describe API (#1080) Summary: Pull Request resolved: #1080 Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112

facebook-github-bot · 2025-06-13T00:23:14Z

This pull request was exported from Phabricator. Differential Revision: D76485112

…'s describe API (#1080) Summary: Pull Request resolved: #1080 Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112

…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112

facebook-github-bot · 2025-06-13T05:11:37Z

This pull request was exported from Phabricator. Differential Revision: D76485112

…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112

facebook-github-bot · 2025-06-13T05:35:32Z

This pull request was exported from Phabricator. Differential Revision: D76485112

…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112

facebook-github-bot · 2025-06-13T06:21:02Z

This pull request was exported from Phabricator. Differential Revision: D76485112

…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112

facebook-github-bot · 2025-06-13T14:46:08Z

This pull request was exported from Phabricator. Differential Revision: D76485112

…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112

facebook-github-bot · 2025-06-13T14:46:38Z

This pull request was exported from Phabricator. Differential Revision: D76485112

…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112

facebook-github-bot · 2025-06-13T14:55:44Z

This pull request was exported from Phabricator. Differential Revision: D76485112

…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112

facebook-github-bot · 2025-06-13T15:14:21Z

This pull request was exported from Phabricator. Differential Revision: D76485112

…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112

facebook-github-bot · 2025-06-13T15:48:24Z

This pull request was exported from Phabricator. Differential Revision: D76485112

…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112

facebook-github-bot · 2025-06-13T19:03:28Z

This pull request was exported from Phabricator. Differential Revision: D76485112

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 12, 2025

facebook-github-bot added the fb-exported label Jun 12, 2025

kiukchung requested review from d4l3k June 12, 2025 19:19

d4l3k requested changes Jun 12, 2025

View reviewed changes

torchx/schedulers/slurm_scheduler.py Outdated Show resolved Hide resolved

facebook-github-bot force-pushed the export-D76485112 branch from 707637e to b700e74 Compare June 12, 2025 21:02

d4l3k approved these changes Jun 12, 2025

View reviewed changes

kiukchung force-pushed the export-D76485112 branch from b700e74 to 6eca839 Compare June 12, 2025 22:10

facebook-github-bot force-pushed the export-D76485112 branch from 6eca839 to 3a3772c Compare June 12, 2025 22:11

kiukchung force-pushed the export-D76485112 branch from 3a3772c to d94f744 Compare June 12, 2025 22:13

kiukchung force-pushed the export-D76485112 branch from d94f744 to 256b6fe Compare June 12, 2025 23:32

kiukchung force-pushed the export-D76485112 branch from 256b6fe to 8659984 Compare June 13, 2025 00:06

kiukchung force-pushed the export-D76485112 branch from 8659984 to ff1e48f Compare June 13, 2025 00:12

kiukchung force-pushed the export-D76485112 branch from ff1e48f to 0489983 Compare June 13, 2025 00:23

kiukchung force-pushed the export-D76485112 branch from 3cabe4c to 21e2174 Compare June 13, 2025 03:32

facebook-github-bot force-pushed the export-D76485112 branch from 21e2174 to 80924d9 Compare June 13, 2025 05:11

facebook-github-bot force-pushed the export-D76485112 branch from 80924d9 to 01bc1cd Compare June 13, 2025 05:35

facebook-github-bot force-pushed the export-D76485112 branch from 01bc1cd to cf83fbd Compare June 13, 2025 06:20

facebook-github-bot force-pushed the export-D76485112 branch from cf83fbd to 811a65f Compare June 13, 2025 14:45

facebook-github-bot force-pushed the export-D76485112 branch from 811a65f to cc6ef31 Compare June 13, 2025 14:46

facebook-github-bot force-pushed the export-D76485112 branch from cc6ef31 to 5e2fad7 Compare June 13, 2025 14:55

facebook-github-bot force-pushed the export-D76485112 branch from 5e2fad7 to 923250a Compare June 13, 2025 15:14

facebook-github-bot force-pushed the export-D76485112 branch from 923250a to bd24bf9 Compare June 13, 2025 15:48

(torchx/scheduler) Fill hostnames for each replica in slurm scheduler…

ba2ffea

…'s describe API (#1080) Summary: Additionally fill hostname, resource (cpu, memMB), image, entrypoint in `describe_squeue` for each role/replica. Reviewed By: d4l3k Differential Revision: D76485112

facebook-github-bot force-pushed the export-D76485112 branch from bd24bf9 to ba2ffea Compare June 13, 2025 19:03

facebook-github-bot merged commit 34d6b83 into main Jun 13, 2025
22 of 24 checks passed

facebook-github-bot deleted the export-D76485112 branch June 13, 2025 23:05

(torchx/scheduler) Fill hostnames for each replica in slurm scheduler's describe API #1080

(torchx/scheduler) Fill hostnames for each replica in slurm scheduler's describe API #1080

Conversation

kiukchung commented Jun 12, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

d4l3k left a comment

Choose a reason for hiding this comment

Uh oh!

d4l3k Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

kiukchung Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

Uh oh!

Uh oh!