Improve custom ops tutorials #3020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3020
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0310be6 with merge base fc016bd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
svekars
reviewed
Aug 28, 2024
| @@ -174,6 +174,8 @@ To add ``torch.compile`` support for an operator, we must add a FakeTensor kerne | |||
| known as a "meta kernel" or "abstract impl"). FakeTensors are Tensors that have | |||
| metadata (such as shape, dtype, device) but no data: the FakeTensor kernel for an | |||
| operator specifies how to compute the metadata of output tensors given the metadata of input tensors. | |||
| The FakeTensor kernel should return return dummy Tensors of your choice with | |||
| the correct Tensor metadata (shape/strides/``dtype``/device). | |||
There was a problem hiding this comment.
Should this be in double ticks?
Suggested change
| the correct Tensor metadata (shape/strides/``dtype``/device). | |
| the correct Tensor metadata (``shape/strides/<dtype>/device``). |
There was a problem hiding this comment.
I just wanted to put dtype in double ticks because it's not an english word
zou3519
force-pushed
the
rzou/improve_custom_ops
branch
from
0ec6dbd
to
5ea69b0
Compare
svekars
approved these changes
Aug 28, 2024
c-p-i-o
pushed a commit
that referenced
this pull request
Sep 6, 2024
Co-authored-by: Svetlana Karslioglu <[email protected]>
c-p-i-o
pushed a commit
that referenced
this pull request
Sep 6, 2024
Co-authored-by: Svetlana Karslioglu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pytorch/pytorch#133318
Description
We update the custom ops tutorials based on user feedback.
Checklist