A denormalization example in the dockblock for transforms.Normalize#8835
A denormalization example in the dockblock for transforms.Normalize#8835hijarian wants to merge 1 commit intopytorch:mainfrom
Conversation
For transforms.Normalize, added an explanation in the docblock on how to revert the performed normalization.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8835
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @hijarian! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for the PR @hijarian . Honestly, I'm not sure there is much value in documenting this. It is a rather trivial operation to reverse with basic math, and there are already snippets that are easy to find in the repo (those you found above). So I would lean towards not merging this, sorry. |
For the
transforms.Normalize, added an explanation in the docblock on how to revert the performed normalization.Covers #281 and #528 as the best tradeoff.