Skip to content

Follow 2 releases grace period for API deprecation #8003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2024
Merged

Follow 2 releases grace period for API deprecation #8003

merged 1 commit into from
Sep 12, 2024

Conversation

zpcore
Copy link
Member

@zpcore zpcore commented Sep 12, 2024

Update the deprecation message to remove in 2.7 releases to be follow the 6 months grace period rule.

@zpcore zpcore marked this pull request as ready for review September 12, 2024 22:00
@zpcore zpcore requested a review from ManfeiBai September 12, 2024 22:00
@zpcore zpcore mentioned this pull request Sep 12, 2024
Closed
ManfeiBai
ManfeiBai approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

let's have this cherry-picked in 2.5 release branch too

@zpcore zpcore merged commit 9992480 into master Sep 12, 2024
21 of 23 checks passed
ManfeiBai pushed a commit that referenced this pull request Sep 23, 2024
@zpcore @ManfeiBai
Follow 2 releases grace period for API deprecation (#8003)
ba13b4e
@ManfeiBai ManfeiBai mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManfeiBai ManfeiBai ManfeiBai approved these changes

Assignees
No one assigned
Labels
2.5 release backport_2.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zpcore @ManfeiBai