Re-introduce "XLA_USE_32BIT_LONG" flag #8589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #8571
In this PR, we reintroduce the
XLA_USE_32BIT_LONGflag to give customers the flexibility to use INT32 for their workloads. This was previously removed in 2.5 in #7582. PyTorch's inept INT32 support across the board (pytorch/pytorch#141994) remains an issue, but given that some hw compilers do not support 64-bit types, this helps unblock customers who require this implicit XLA downcasting.There were previously no tests for
XLA_USE_32BIT_LONG, so simultaneously refined the test to not require specifying the flag prior to calling the test, and extending the tests to capture more cases.