Improve and refine MLP tests for extensibility and A/B testing #8590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeffhataws @tengyifei PTAL |
|
@rpsilva-aws this PR has 10 commits. Is there a reason it didn't cherrypick the single squashed commit that was merged into the master branch? |
rpsilva-aws
force-pushed
the
rpsilva_r2.6_mlp_ab_test
branch
from
1ffa69d to
0dd7d63
Compare
|
@tengyifei There was a clash in one of the commits, so I was individually cherry-picking each commit to validate. It wasn't an actual difference, so I just squashed it now. |
|
Ack |
tengyifei
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #8561
In this PR, we include various fixes, improvements and extensions, namely: