remove version number from nightly build references #9130
Conversation
|
@bhavya01 in what other repositories can this be updated? I found https://github.com/GoogleCloudPlatform/ml-auto-solutions/blob/master/dags/legacy_test/tests/pytorch/nightly/common.libsonnet#L108 |
| | nightly (Python 3.10) | `https://storage.googleapis.com/pytorch-xla-releases/wheels/tpuvm/torch_xla-2.8.0.dev-cp310-cp310-linux_x86_64.whl` | | ||
| | nightly (Python 3.11) | `https://storage.googleapis.com/pytorch-xla-releases/wheels/tpuvm/torch_xla-2.8.0.dev-cp311-cp311-linux_x86_64.whl` | | ||
| | nightly (CUDA 12.6 + Python 3.10) | `https://storage.googleapis.com/pytorch-xla-releases/wheels/cuda/12.6/torch_xla-2.8.0.dev-cp310-cp310-linux_x86_64.whl` | | ||
| | nightly (Python 3.9) | `https://storage.googleapis.com/pytorch-xla-releases/wheels/tpuvm/torch_xla.dev-cp39-cp39-linux_x86_64.whl` | |
There was a problem hiding this comment.
This link doesn't work. But neither does the current link, with the version number. Where's the github action that performs the nightly build?
| | nightly (Python 3.10) | `https://storage.googleapis.com/pytorch-xla-releases/wheels/tpuvm/torch_xla.dev-cp310-cp310-linux_x86_64.whl` | | ||
| | nightly (Python 3.11) | `https://storage.googleapis.com/pytorch-xla-releases/wheels/tpuvm/torch_xla.dev-cp311-cp311-linux_x86_64.whl` | | ||
| | nightly (CUDA 12.6 + Python 3.10) | `https://storage.googleapis.com/pytorch-xla-releases/wheels/cuda/12.6/torch_xla.dev-cp310-cp310-linux_x86_64.whl` | |
There was a problem hiding this comment.
These links all work
README.md
Outdated
| @@ -34,7 +34,7 @@ To install PyTorch/XLA nightly build in a new TPU VM: | |||
| ```sh | |||
| pip install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cpu | |||
| # Edit `cp310-cp310` to fit your desired Python version as needed | |||
| pip install 'torch_xla[tpu] @ https://storage.googleapis.com/pytorch-xla-releases/wheels/tpuvm/torch_xla-2.8.0.dev-cp310-cp310-linux_x86_64.whl' \ | |||
| pip install 'torch_xla[tpu] @ https://storage.googleapis.com/pytorch-xla-releases/wheels/tpuvm/torch_xla.dev-cp310-cp310-linux_x86_64.whl' \ | |||
There was a problem hiding this comment.
When trying to do this, I got an error saying that ERROR: Invalid wheel filename (wrong number of parts): 'torch_xla.dev-cp310-cp310-linux_x86_64'
Sorry, I didn't notice earlier that python wheel naming conventions always require a version number https://packaging.python.org/en/latest/specifications/binary-distribution-format/#file-name-convention
Should we leave this as it is?
I have a proposal to upload our packages to a download.pytorch.org and plan to create an RFC for it on pytorch repo
No description provided.