custom_call
: improve error handling and error messages.
#9680
+192
−113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
custom_call
implementation by improving its error message, and returning a status type value.Key Changes:
tensor_methods::{tpu,}custom_call
returnStatusOr<vector<XLATensorPtr>>
CheckCustomCallNonEmptyInputs
function for checking if there' at least 1 input tensorCheckCustomCallOutputPropertiesSize
function for checking if the given shapes and dtypes match in size, i.e. they agree on the number of outputsCustomCallImpl
function for implementing bothcustom_call
andtpu_custom_call
, since they did mostly the same thingCheckIntList
function (should have been deleted in #9648)TpuCustomCall
function, inlining it in its corresponding Python binding, which is howcustom_call
binding is currently implementedExample 1: no inputs
Comparison
Before:
After:
Example 2: output properties size mismatch
Comparison
Before:
After: