-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slstr #98
base: main
Are you sure you want to change the base?
Add slstr #98
Conversation
inst = np.tile(inst[:, np.newaxis, :], [1, np.int32(scans_nb), 1]) | ||
|
||
times = np.tile(np.zeros_like(scanline_angles), [np.int32(scans_nb), 1]) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W293 blank line contains whitespace
pyorbital/tests/test_geoloc.py
Outdated
"""Test the definition of the slstr instrument flying on Sentinel-3 | ||
""" | ||
geom = slstr(1, [0, 1]) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W293 blank line contains whitespace
Codecov Report
@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 86.86% 86.89% +0.03%
==========================================
Files 13 13
Lines 2048 2068 +20
==========================================
+ Hits 1779 1797 +18
- Misses 269 271 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Could someone add appropriate tags to this issue? And who can review this? |
This PR is needed before issue 69 in pytroll-schedule can reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this, just a couple of comments
@@ -553,3 +553,33 @@ def ascat(scan_nb, scan_points=None): | |||
[np.int32(scan_nb), 1]) + np.expand_dims(offset, 1)) | |||
|
|||
return ScanGeometry(inst, times) | |||
|
|||
|
|||
def slstr(scans_nb, scan_points=None, is_nadir=True): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be called eg slstr_nadir
?
|
||
if scan_points is None: | ||
scan_len = 3000 # samples per scan | ||
scan_points = np.arange(3000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scan_points = np.arange(3000) | |
scan_points = np.arange(scan_len) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be tested also.
@TAlonglong |
flake8 pyorbital