Fix a vulnerability regarding character deletion#254
Merged
GhzGarage merged 1 commit intoqbcore-framework:mainfrom Nov 13, 2024
Merged
Fix a vulnerability regarding character deletion#254GhzGarage merged 1 commit intoqbcore-framework:mainfrom
GhzGarage merged 1 commit intoqbcore-framework:mainfrom
Conversation
This will disallow cheaters (anyone with a LUA script executor) from deleting their characters, bypassing the `Config.EnableDeleteButton` setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Pull request
This will disallow cheaters (anyone with a LUA script executor) from deleting their characters, bypassing the
Config.EnableDeleteButtonsetting. This is done by simply making sureConfig.EnableDeleteButtonistrue, before deleting the character inqb-multicharacter:server:deleteCharacterIf your PR is to fix an issue mention that issue here
#253
Questions (please complete the following information):