Skip to content

Conversation

@Troughy
Copy link
Contributor

@Troughy Troughy commented Sep 30, 2024

Describe Pull request
This will disallow cheaters (anyone with a LUA script executor) from deleting their characters, bypassing the Config.EnableDeleteButton setting. This is done by simply making sure Config.EnableDeleteButton is true, before deleting the character in qb-multicharacter:server:deleteCharacter

If your PR is to fix an issue mention that issue here
#253

Questions (please complete the following information):

  • Have you personally loaded this code into an updated qbcore project and checked all it's functionality? yes
  • Does your code fit the style guidelines? yes
  • Does your PR fit the contribution guidelines? yes

This will disallow cheaters (anyone with a LUA script executor) from deleting their characters, bypassing the `Config.EnableDeleteButton` setting.
@GhzGarage GhzGarage merged commit f2fb43e into qbcore-framework:main Nov 13, 2024
1 of 2 checks passed
@Troughy Troughy deleted the Troughy-patch-1 branch November 14, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] The value of the config option for the delete character button is not actually checked before deleting the character

2 participants