Skip to content

Migration of models to dataclasses #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Feb 15, 2025
Merged

Conversation

I8dNLo
Copy link
Contributor

@I8dNLo I8dNLo commented Feb 11, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass the existing tests?
  • Have you added tests for your feature?
  • Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

New models submission:

  • Have you added an explanation of why it's important to include this model?
  • Have you added tests for the new model? Were canonical values for tests computed via the original model?
  • Have you added the code snippet for how canonical values were computed?
  • Have you successfully ran tests with your changes locally?

@I8dNLo I8dNLo changed the title Draft Migration of models to dataclasses Migration of models to dataclasses Feb 11, 2025
@joein joein force-pushed the dataclasses_for_supported_models branch from 743cfce to 997272c Compare February 15, 2025 22:04
@joein joein merged commit b389798 into main Feb 15, 2025
22 checks passed
@joein joein deleted the dataclasses_for_supported_models branch February 15, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants