Update setting jina v3 tasks #503
Conversation
joein
force-pushed
the
update-setting-jina-v3-tasks
branch
from
93e1022 to
0d5821d
Compare
📝 WalkthroughWalkthroughThe changes revise how task identifiers are handled in the embedding modules. The main embedding class now accepts an optional task identifier during initialization, replacing the previous mutable state. The preprocessing and embedding methods have been updated to require an explicit task ID—raising an error if it is absent—and to default to a preset value when necessary. In the worker class, the initialization is adjusted to return a new instance directly, and a new batch processing method is added. Additionally, the ONNX text model’s document embedding method has been updated to forward extra keyword arguments to the underlying embedding function. Finally, the test suite has been modified to include new assertions for verifying embedding shapes and consistency, and an obsolete test function has been removed. Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/python-tests.yml (1)
46-46: Append Newline at End of FileYAMLlint has flagged a missing newline at the end of the file. Please insert a newline after line 46 to satisfy linting requirements.
Below is a diff snippet for the required change:
-HF_TOKEN=${{ secrets.HF_TOKEN }} poetry run pytest\ No newline at end of file +HF_TOKEN=${{ secrets.HF_TOKEN }} poetry run pytest +🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 46-46: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/python-tests.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/python-tests.yml
[error] 46-46: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Python 3.13 test
🔇 Additional comments (1)
.github/workflows/python-tests.yml (1)
46-46: Enhanced Secret Injection in Pytest Run StepThe update correctly assigns
HF_TOKENfrom the repository secrets before invokingpoetry run pytest, ensuring that authentication or configuration data is available during test execution.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 46-46: no new line character at the end of file
(new-line-at-end-of-file)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/python-tests.yml (1)
48-48: Missing New Line at End of File
YAML linting indicates that there is no new line character at the end of the file. Please add a new line at the end of the file to adhere to YAML formatting standards.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 48-48: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/python-tests.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/python-tests.yml
[error] 48-48: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms (12)
- GitHub Check: Python 3.13.x on windows-latest test
- GitHub Check: Python 3.13.x on macos-latest test
- GitHub Check: Python 3.12.x on windows-latest test
- GitHub Check: Python 3.12.x on macos-latest test
- GitHub Check: Python 3.12.x on ubuntu-latest test
- GitHub Check: Python 3.11.x on windows-latest test
- GitHub Check: Python 3.11.x on macos-latest test
- GitHub Check: Python 3.10.x on windows-latest test
- GitHub Check: Python 3.10.x on macos-latest test
- GitHub Check: Python 3.13 test
- GitHub Check: Python 3.9.x on windows-latest test
- GitHub Check: Python 3.9.x on macos-latest test
🔇 Additional comments (1)
.github/workflows/python-tests.yml (1)
45-48: Environment Variable Addition for HF_TOKEN
The addedenvblock settingHF_TOKEN: ${{ secrets.HF_TOKEN }}in the "Run pytest" step is correctly implemented and ensures that the tests have access to the necessary credentials during execution.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 48-48: no new line character at the end of file
(new-line-at-end-of-file)
No description provided.